NEW 36997
LayoutTests/http/tests/cookies/double-quoted-value-with-semi-colon.html should not use a new-style cookie
https://bugs.webkit.org/show_bug.cgi?id=36997
Summary LayoutTests/http/tests/cookies/double-quoted-value-with-semi-colon.html shoul...
David Kilzer (:ddkilzer)
Reported 2010-04-01 17:45:20 PDT
* SUMMARY LayoutTests/http/tests/cookies/double-quoted-value-with-semi-colon.html uses a "Version=1", new-style cookie (as specified in <http://www.ietf.org/rfc/rfc2109.txt>). However, the cookie testing code doesn't support this type of cookie yet, so it should be changed back to an original-style cookie.
Attachments
Patch v1 (1.49 KB, patch)
2010-04-01 17:51 PDT, David Kilzer (:ddkilzer)
abarth: review-
David Kilzer (:ddkilzer)
Comment 1 2010-04-01 17:46:12 PDT
I filed Bug 36998 to add support for testing RFC-2109-style cookies.
David Kilzer (:ddkilzer)
Comment 2 2010-04-01 17:51:39 PDT
Created attachment 52359 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 3 2010-04-01 18:52:49 PDT
Eric Seidel (no email)
Comment 4 2010-04-01 23:46:07 PDT
Adam says this test is wrong. I've CC'd him and he can explain why.
Adam Barth
Comment 5 2010-04-01 23:51:52 PDT
This cookie isn't correct according to the new cookie spec: https://datatracker.ietf.org/doc/draft-ietf-httpstate-cookie/ Quoted cookie values were a fantasy invented by 2109 to cause pain in the world.
Adam Barth
Comment 6 2010-04-02 09:43:55 PDT
Comment on attachment 52359 [details] Patch v1 The line of code should read: cookiesShouldBe('disorder="477beccb;richard";Path=/', 'disorder="477beccb'); I'd rather we tested non-esoteric properties of cookies before testing this particular case (which is wrong in CFNetwork).
David Kilzer (:ddkilzer)
Comment 7 2010-04-03 16:50:17 PDT
Perhaps we should simply remove the test. Is there a related test in your test suite? I've updated Bug 36998 for importing your cookie test suite rather than writing tests for RFC 2109.
Note You need to log in before you can comment on or make changes to this bug.