Bug 36997 - LayoutTests/http/tests/cookies/double-quoted-value-with-semi-colon.html should not use a new-style cookie
Summary: LayoutTests/http/tests/cookies/double-quoted-value-with-semi-colon.html shoul...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 16699
Blocks:
  Show dependency tree / graph
 
Reported: 2010-04-01 17:45 PDT by David Kilzer (:ddkilzer)
Modified: 2010-06-11 10:42 PDT (History)
3 users (show)

See Also:

Attachments
Patch v1 (1.49 KB, patch)
2010-04-01 17:51 PDT, David Kilzer (:ddkilzer) 		abarth: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2010-04-01 17:45:20 PDT 
* SUMMARY
LayoutTests/http/tests/cookies/double-quoted-value-with-semi-colon.html uses a "Version=1", new-style cookie (as specified in <http://www.ietf.org/rfc/rfc2109.txt>).  However, the cookie testing code doesn't support this type of cookie yet, so it should be changed back to an original-style cookie.
Comment 1 David Kilzer (:ddkilzer) 2010-04-01 17:46:12 PDT 
I filed Bug 36998 to add support for testing RFC-2109-style cookies.
Comment 2 David Kilzer (:ddkilzer) 2010-04-01 17:51:39 PDT 
Created attachment 52359 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2010-04-01 18:52:49 PDT 
<rdar://problem/7767948>
Comment 4 Eric Seidel (no email) 2010-04-01 23:46:07 PDT 
Adam says this test is wrong.  I've CC'd him and he can explain why.
Comment 5 Adam Barth 2010-04-01 23:51:52 PDT 
This cookie isn't correct according to the new cookie spec:

https://datatracker.ietf.org/doc/draft-ietf-httpstate-cookie/

Quoted cookie values were a fantasy invented by 2109 to cause pain in the world.
Comment 6 Adam Barth 2010-04-02 09:43:55 PDT 
Comment on attachment 52359 [details]
Patch v1

The line of code should read:

cookiesShouldBe('disorder="477beccb;richard";Path=/', 'disorder="477beccb');

I'd rather we tested non-esoteric properties of cookies before testing this particular case (which is wrong in CFNetwork).
Comment 7 David Kilzer (:ddkilzer) 2010-04-03 16:50:17 PDT 
Perhaps we should simply remove the test.

Is there a related test in your test suite?

I've updated Bug 36998 for importing your cookie test suite rather than writing tests for RFC 2109.