Bug 36995 - Improve the error handling in rollout a bit
Summary: Improve the error handling in rollout a bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-01 17:43 PDT by Adam Barth
Modified: 2010-04-01 21:32 PDT (History)
1 user (show)

See Also:


Attachments
Patch (11.40 KB, patch)
2010-04-01 17:53 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (10.42 KB, patch)
2010-04-01 18:53 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (10.66 KB, patch)
2010-04-01 20:49 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-04-01 17:43:51 PDT
Improve the error handling in rollout a bit
Comment 1 Adam Barth 2010-04-01 17:53:02 PDT
Created attachment 52360 [details]
Patch
Comment 2 Adam Barth 2010-04-01 18:50:58 PDT
Comment on attachment 52360 [details]
Patch

dave_levin broke my patch.  Will re-spin.
Comment 3 Adam Barth 2010-04-01 18:53:59 PDT
Created attachment 52365 [details]
Patch
Comment 4 Eric Seidel (no email) 2010-04-01 20:36:47 PDT
Comment on attachment 52365 [details]
Patch

Explain why in your comment, please:
            # Note: Don't print a bug URL here because it will confuse the
 259             #       SheriffBot.  Yes, that's lame.
 260             log("Preparing rollout for bug %s." % commit_info.bug_id())
 261

cc_list?
 267         cc = sorted([party.bugzilla_email()

We should be passing around lists instead of a string:
 273             "bug_cc": ",".join(cc),

Anyway, this looks fine.  We should fix the cc passing around at some point.  Ideally now, but not required.  Either way I don't need to see this again.
Comment 5 Adam Barth 2010-04-01 20:49:56 PDT
Created attachment 52370 [details]
Patch for landing
Comment 6 Adam Barth 2010-04-01 21:32:01 PDT
Comment on attachment 52370 [details]
Patch for landing

Clearing flags on attachment: 52370

Committed r56964: <http://trac.webkit.org/changeset/56964>
Comment 7 Adam Barth 2010-04-01 21:32:09 PDT
All reviewed patches have been landed.  Closing bug.