Bug 36982 – [Chromium]: FindInPage issue with scrollbars not updated on frame pages

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Finnur Thorarinsson]

With Chromium, executing a FindInPage on multi-frame pages doesn't always update tickmarks on scrollbars for the subframes (sometimes it works, sometimes partially, sometimes not a all).

There is a reduction here (comment 23):
http://code.google.com/p/chromium/issues/detail?id=13551#c23

Turns out the Invalidate function is calling invalidateRect on the View and is specifying a rect that's in window coordinates, whereas the invalidateRect expects frame coordinates.

Patch coming.

[Finnur Thorarinsson]

Created attachment 52335 [details]
Proposed patch for fixing the paint problem

[WebKit Review Bot]

Attachment 52335 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/src/WebFrameImpl.cpp:1966:  frame_rect is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit/chromium/src/WebFrameImpl.cpp:1977:  frame_rect is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Finnur Thorarinsson]

Created attachment 52336 [details]
Now with style issue fixed

[WebKit Review Bot]

Attachment 52336 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/ChangeLog:5:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Finnur Thorarinsson]

Created attachment 52341 [details]
Changed CRLF to LF to appease the style gods :)

[Eric Seidel (no email)]

Comment on attachment 52341 [details]
Changed CRLF to LF to appease the style gods :)

I don't know what Chromium's policy on testing this sort of thing is.  I assume a manual test would be possible, but I'm not sure there is an automated way to test this.  Or maybe there is?

I'm not the expert on this code, but this looks sane.

[WebKit Commit Bot]

Comment on attachment 52341 [details]
Changed CRLF to LF to appease the style gods :)

Clearing flags on attachment: 52341

Committed r56958: <http://trac.webkit.org/changeset/56958>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.