Bug 36980 - Add object addresses to debug showLayerTree() output.
Summary: Add object addresses to debug showLayerTree() output.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-01 14:03 PDT by Simon Fraser (smfr)
Modified: 2010-04-01 16:46 PDT (History)
1 user (show)

See Also:

Attachments
Patch (7.27 KB, patch)
2010-04-01 14:18 PDT, Simon Fraser (smfr) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-04-01 14:03:49 PDT 
It would be useful if showLayerTree() when called from gdb showed the object addresses.
Comment 1 Simon Fraser (smfr) 2010-04-01 14:18:46 PDT 
Created attachment 52334 [details]
Patch
Comment 2 Darin Adler 2010-04-01 16:16:39 PDT 
Comment on attachment 52334 [details]
Patch

> +    if (behavior & RenderAsTextShowAddresses)
> +        ts << " " << static_cast<const void*>(&o);

What happens if you don't do the static_cast? Does it fail to compile? Can you leave the cast out?

r=me
Comment 3 Simon Fraser (smfr) 2010-04-01 16:46:20 PDT 
I was able to remove the casts!
http://trac.webkit.org/changeset/56948