While playing with cursors, I found out that if I set a cursor to a window that hosts a WebKitWebView, it will be disregarded. Also, even if it is set explicitely on the WebKitWebView widget, it will go back to being the white pointer after it has changed into something else, and back. It should likely not use GDK_LEFT_PTR explicitely.
Created attachment 52300 [details] This is not a joke.
Attachment 52300 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/gtk/CursorGtk.cpp:93: Use 0 instead of NULL. [readability/null] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
What about when a website specifies pointer cursor over a specific region? Won't this change cause those sites to break?
(In reply to comment #3) > What about when a website specifies pointer cursor over a specific region? > Won't this change cause those sites to break? It should not. What the change does is make sure that when the web site requests 'pointer', that the cursor will become whatever the user (or the application) has chosen the pointer cursor to be, so I believe that is the correct behaviour.
Created attachment 54056 [details] remove assert, as discussed with xan
Attachment 54056 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/gtk/CursorGtk.cpp:92: Use 0 instead of NULL. [readability/null] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 54056 [details] remove assert, as discussed with xan r=me
Landed as r58531.