Bug 36929 – [Qt] REGRESSION(r56869): Windows build is broken

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

http://trac.webkit.org/changeset/56869 broke QtWebKit build on Windows
(MinGW and MSVC build)

missing ARRAYSIZE macro: (only with MinGW)
-------------------------------------------
..\..\..\WebCore\platform\UUID.cpp: In function 'WebCore::String WebCore::createCanonicalUUIDString()':
..\..\..\WebCore\platform\UUID.cpp:54: error: 'ARRAYSIZE' was not declared in this scope
make.exe[1]: *** [obj/release/UUID.o] Error 1

missing CoCreateGuid() and StringFromGUID2() (Ole32.lib)
---------------------------------------------------------
c:/qt/2010.02/mingw/bin/../lib/gcc/mingw32/4.4.0/../../../../mingw32/bin/ld.exe: :0: syntax error
Warning: .drectve `-export:T.4466 ' unrecognized
./obj\release\UUID.o:UUID.cpp:(.text+0x1e): undefined reference to `CoCreateGuid@4'
./obj\release\UUID.o:UUID.cpp:(.text+0x3a): undefined reference to `StringFromGUID2@12'
collect2: ld returned 1 exit status
make.exe[1]: *** [..\lib\QtWebKit4.dll] Error 1

[Csaba Osztrogonác]

Created attachment 52259 [details]
proposed fix

Missing "LIBS += -lOle32" added.

Missing ARRAYSIZE macro definition added if it isn't defined before. (copied from:
\Program Files\Microsoft Platform SDK for Windows Server 2003 R2\Include\CeLib.h)

[WebKit Review Bot]

Attachment 52259 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/UUID.cpp:39:  Missing spaces around /  [whitespace/operators] [3]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Csaba Osztrogonác]

Created attachment 52260 [details]
proposed fix

style fixed

[Eric Seidel (no email)]

I see ARRAYSIZE_UNSAFE in:
http://trac.webkit.org/changeset/53634

I thought we had an ARRAYSIZE macro in wtf/StdLibExtras.h, but we don't seem to.

[Jian Li]

Comment on attachment 52260 [details]
proposed fix

r=me

[Csaba Osztrogonác]

(In reply to comment #5)
> (From update of attachment 52260 [details])
> r=me

Landed in http://trac.webkit.org/changeset/56922

[Csaba Osztrogonác]

Created attachment 55097 [details]
WinCE buildfix

[Csaba Osztrogonác]

WinCE build is broken too, fix attached here.
See comments in https://bugs.webkit.org/show_bug.cgi?id=36472

[Simon Hausmann]

Comment on attachment 55097 [details]
WinCE buildfix

rs=me

[Csaba Osztrogonác]

(In reply to comment #9)
> (From update of attachment 55097 [details])
> rs=me

Landed in http://trac.webkit.org/changeset/58813

[WebKit Review Bot]

http://trac.webkit.org/changeset/58813 might have broken Qt Linux Release