Bug 36918 - set-progress-properties.html expected result should not be platform specific
Summary: set-progress-properties.html expected result should not be platform specific
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-31 18:46 PDT by Yael
Modified: 2010-04-01 11:24 PDT (History)
2 users (show)

See Also:


Attachments
Patch to move the test result (3.43 KB, patch)
2010-03-31 18:56 PDT, Yael
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2010-03-31 18:46:17 PDT
Originally, the expected result was committed under LayoutTests\platform\qt.
This JavaScript based test should have the same result for all platforms that do not skip the test.
Comment 1 Yael 2010-03-31 18:56:26 PDT
Created attachment 52235 [details]
Patch to move the test result
Comment 2 Laszlo Gombos 2010-04-01 06:32:18 PDT
Comment on attachment 52235 [details]
Patch to move the test result

It looks correct to me move the expected file to the common set, r+.
Comment 3 WebKit Commit Bot 2010-04-01 06:51:27 PDT
Comment on attachment 52235 [details]
Patch to move the test result

Rejecting patch 52235 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 12599 test cases.
fast/canvas/webgl/index-validation.html -> failed

Exiting early after 1 failures. 5076 tests run.
81.01s total testing time

5075 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
1 test case (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/1666025
Comment 4 Yael 2010-04-01 06:56:00 PDT
Comment on attachment 52235 [details]
Patch to move the test result

This patch is moving an expected result around. It is most likely not the reason for fast/canvas/webgl/index-validation.html to fail.
Comment 5 WebKit Commit Bot 2010-04-01 07:13:03 PDT
Comment on attachment 52235 [details]
Patch to move the test result

Clearing flags on attachment: 52235

Committed r56912: <http://trac.webkit.org/changeset/56912>
Comment 6 WebKit Commit Bot 2010-04-01 07:13:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Eric Seidel (no email) 2010-04-01 11:24:54 PDT
Correct.  You hit bug 36908.