Bug 36910 - 3 test failures on Snow Leopard bot from 33416
Summary: 3 test failures on Snow Leopard bot from 33416
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Zhenyao Mo
Depends on:
Reported: 2010-03-31 17:44 PDT by Kenneth Russell
Modified: 2010-03-31 19:09 PDT (History)
6 users (show)

See Also:

patch (9.14 KB, patch)
2010-03-31 18:30 PDT, Zhenyao Mo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-03-31 17:44:54 PDT
Per comment 40 on bug 33416, there are three WebGL test failures on the Snow Leopard bot introduced by this patch because the EXT_packed_depth_stencil extension is unsupported. The tests are incorrect; according to the WebGL spec, it is legal for an implementation to not be able to honor the request for a stencil buffer.
Comment 1 Zhenyao Mo 2010-03-31 18:30:22 PDT
Created attachment 52231 [details]
Comment 2 Eric Seidel (no email) 2010-03-31 18:34:30 PDT
Comment on attachment 52231 [details]

Someone who actually knows WebGL should do a review here. Or a non-reviewer who knows WebGL could explain why this is right and then I'm happy to r+. :)
Comment 3 Kenneth Russell 2010-03-31 18:47:08 PDT
Comment on attachment 52231 [details]

The patch looks good to me. Based on this behavior I think we might want to reconsider some of the rules in the WebGL spec, but this is beyond the scope of this fix.
Comment 4 Eric Seidel (no email) 2010-03-31 18:56:47 PDT
Comment on attachment 52231 [details]

Seems reasonable.  Thank you for the quick fix.
Comment 5 WebKit Commit Bot 2010-03-31 19:09:06 PDT
Comment on attachment 52231 [details]

Clearing flags on attachment: 52231

Committed r56886: <http://trac.webkit.org/changeset/56886>
Comment 6 WebKit Commit Bot 2010-03-31 19:09:11 PDT
All reviewed patches have been landed.  Closing bug.