Bug 36892 - [V8] SerializedScriptValue must be deserialized only once and in the right context
Summary: [V8] SerializedScriptValue must be deserialized only once and in the right co...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-31 11:03 PDT by Vitaly Repeshko
Modified: 2010-03-31 17:10 PDT (History)
2 users (show)

See Also:


Attachments
patch v1 (7.08 KB, patch)
2010-03-31 11:13 PDT, Vitaly Repeshko
levin: review+
levin: commit-queue-
Details | Formatted Diff | Diff
patch v1.1 (7.08 KB, patch)
2010-03-31 13:17 PDT, Vitaly Repeshko
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Repeshko 2010-03-31 11:03:01 PDT
[V8] SerializedScriptValue must be deserialized only once and in the right context
Comment 1 Vitaly Repeshko 2010-03-31 11:13:51 PDT
Created attachment 52190 [details]
patch v1
Comment 2 David Levin 2010-03-31 11:35:00 PDT
Comment on attachment 52190 [details]
patch v1


> diff --git a/WebCore/bindings/scripts/CodeGeneratorV8.pm b/WebCore/bindings/scripts/CodeGeneratorV8.pm
> +        if ($serializedAttribute->type =~ /^readonly/) {
> +            $attrAttr .= "|v8::ReadOnly";

Ideally add spaces around | (so the code will match the general WK style).
Comment 3 Vitaly Repeshko 2010-03-31 13:17:40 PDT
Created attachment 52205 [details]
patch v1.1
Comment 4 WebKit Commit Bot 2010-03-31 17:10:02 PDT
Comment on attachment 52205 [details]
patch v1.1

Clearing flags on attachment: 52205

Committed r56877: <http://trac.webkit.org/changeset/56877>
Comment 5 WebKit Commit Bot 2010-03-31 17:10:06 PDT
All reviewed patches have been landed.  Closing bug.