Bug 36889 - Misc IndexedDatabase cleanup
Summary: Misc IndexedDatabase cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-31 09:54 PDT by Jeremy Orlow
Modified: 2010-04-01 03:24 PDT (History)
3 users (show)

See Also:


Attachments
Patch (11.28 KB, patch)
2010-03-31 10:03 PDT, Jeremy Orlow
japhet: review+
japhet: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2010-03-31 09:54:42 PDT
Misc IndexedDatabase cleanup
Comment 1 Jeremy Orlow 2010-03-31 10:03:48 PDT
Created attachment 52181 [details]
Patch
Comment 2 WebKit Review Bot 2010-03-31 10:09:51 PDT
Attachment 52181 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/src/IndexedDatabaseProxy.cpp:40:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Nate Chapin 2010-03-31 12:05:45 PDT
Comment on attachment 52181 [details]
Patch

One question (plus the style violation the script caught). I'm r+ing and assuming Darin will override if he sees something I missed in the WebKit/chromium changes.

> --- a/WebKit/chromium/public/WebIndexedDatabase.h
> +++ b/WebKit/chromium/public/WebIndexedDatabase.h
> @@ -36,6 +36,7 @@ namespace WebKit {
>  
>  class WebIDBDatabase;
>  class WebString;
> +class WebFrame;

Do we care about ordering of these?
Comment 4 Jeremy Orlow 2010-03-31 12:12:08 PDT
(In reply to comment #3)
> (From update of attachment 52181 [details])
> One question (plus the style violation the script caught). I'm r+ing and
> assuming Darin will override if he sees something I missed in the
> WebKit/chromium changes.
> 
> > --- a/WebKit/chromium/public/WebIndexedDatabase.h
> > +++ b/WebKit/chromium/public/WebIndexedDatabase.h
> > @@ -36,6 +36,7 @@ namespace WebKit {
> >  
> >  class WebIDBDatabase;
> >  class WebString;
> > +class WebFrame;
> 
> Do we care about ordering of these?

We do.  This is an artifact of me changing it from WebView to WebFrame at some point.  Will fix before landing.
Comment 5 Jeremy Orlow 2010-04-01 03:24:28 PDT
Committed r56907: <http://trac.webkit.org/changeset/56907>