Bug 36887 - [chromium] including WebKit.gyp:webkit should automatically add Skia and NPAPI include paths
Summary: [chromium] including WebKit.gyp:webkit should automatically add Skia and NPAP...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-31 08:52 PDT by Darin Fisher (:fishd, Google)
Modified: 2010-03-31 12:20 PDT (History)
1 user (show)

See Also:

Attachments
v1 patch (1.33 KB, patch)
2010-03-31 08:54 PDT, Darin Fisher (:fishd, Google) 		levin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2010-03-31 08:52:18 PDT 
[chromium] including WebKit.gyp:webkit should automatically add Skia and NPAPI include paths

This is what WebCore.gyp does, and since I'm working to remove direct usage of WebCore.gyp in the Chromium repository, it would be good to do the same for WebKit.gyp.  That way consumers of the WebKit API do not all have to manually include Skia and NPAPI settings.
Comment 1 Darin Fisher (:fishd, Google) 2010-03-31 08:54:37 PDT 
Created attachment 52175 [details]
v1 patch
Comment 2 Darin Fisher (:fishd, Google) 2010-03-31 11:01:12 PDT 
Landed as http://trac.webkit.org/changeset/56853
Comment 3 Adam Barth 2010-03-31 12:18:18 PDT 
http://trac.webkit.org/changeset/56853 appears to have broken Leopard Intel Debug (Tests)
Comment 4 Darin Fisher (:fishd, Google) 2010-03-31 12:20:04 PDT 
(In reply to comment #3)
> http://trac.webkit.org/changeset/56853 appears to have broken Leopard Intel
> Debug (Tests)

That must be unrelated since this was purely a GYP change.