RESOLVED FIXED 36886
test-webkitpy: Have the logtesting tearDown() method check that the array of log messages is empty 
https://bugs.webkit.org/show_bug.cgi?id=36886
Summary test-webkitpy: Have the logtesting tearDown() method check that the array of ...
Chris Jerdonek
Reported 2010-03-31 08:19:09 PDT
If we make the LogTesting class's tearDown() method assert that the array of log messages is empty, we'll get more mileage out of our unit tests that test log messages -- and with less code.
Attachments
Proposed patch (3.26 KB, patch)
2010-03-31 08:56 PDT, Chris Jerdonek 		hamaji: review+
cjerdonek: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Jerdonek
Comment 1 2010-03-31 08:56:45 PDT
Created attachment 52176 [details] Proposed patch
Chris Jerdonek
Comment 2 2010-03-31 21:38:14 PDT
Comment on attachment 52176 [details] Proposed patch cq- to commit manually
Chris Jerdonek
Comment 3 2010-03-31 21:52:37 PDT
Committed: http://trac.webkit.org/changeset/56894
Note You need to log in before you can comment on or make changes to this bug.