Bug 36886 - test-webkitpy: Have the logtesting tearDown() method check that the array of log messages is empty
Summary: test-webkitpy: Have the logtesting tearDown() method check that the array of ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chris Jerdonek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-31 08:19 PDT by Chris Jerdonek
Modified: 2010-03-31 21:52 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (3.26 KB, patch)
2010-03-31 08:56 PDT, Chris Jerdonek 		hamaji: review+
cjerdonek: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jerdonek 2010-03-31 08:19:09 PDT 
If we make the LogTesting class's tearDown() method assert that the array of log messages is empty, we'll get more mileage out of our unit tests that test log messages -- and with less code.
Comment 1 Chris Jerdonek 2010-03-31 08:56:45 PDT 
Created attachment 52176 [details]
Proposed patch
Comment 2 Chris Jerdonek 2010-03-31 21:38:14 PDT 
Comment on attachment 52176 [details]
Proposed patch

cq- to commit manually
Comment 3 Chris Jerdonek 2010-03-31 21:52:37 PDT 
Committed:

http://trac.webkit.org/changeset/56894