WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
36885
Web Inspector: [Chromium] inspector/audits-panel-functional.html crashes test_shell
https://bugs.webkit.org/show_bug.cgi?id=36885
Summary
Web Inspector: [Chromium] inspector/audits-panel-functional.html crashes test...
Alexander Pavlov (apavlov)
Reported
2010-03-31 07:52:29 PDT
Chromium test shell crashes on inspector/audits-panel-functional.html (which works fine during pure WebKit test runs).
Attachments
[PATCH] Suggested solution
(2.04 KB, patch)
2010-03-31 08:00 PDT
,
Alexander Pavlov (apavlov)
pfeldman
: review-
Details
Formatted Diff
Diff
[PATCH] Comments addressed
(1.91 KB, patch)
2010-03-31 08:20 PDT
,
Alexander Pavlov (apavlov)
no flags
Details
Formatted Diff
Diff
[PATCH] CRASH expectation removed
(2.64 KB, patch)
2010-03-31 08:29 PDT
,
Alexander Pavlov (apavlov)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1
2010-03-31 08:00:53 PDT
Created
attachment 52167
[details]
[PATCH] Suggested solution
Pavel Feldman
Comment 2
2010-03-31 08:15:30 PDT
Comment on
attachment 52167
[details]
[PATCH] Suggested solution
> + setTimeout(function() {evaluateInWebInspector("frontend_runAudits", callback)}, 0); > }
This is a hack.
> + testController.waitUntilDone();
Every wait should have notify. To fix your problem, do not call layoutTestController's notifyDone upon first return from the front-end.
Alexander Pavlov (apavlov)
Comment 3
2010-03-31 08:20:51 PDT
Created
attachment 52171
[details]
[PATCH] Comments addressed
Alexander Pavlov (apavlov)
Comment 4
2010-03-31 08:29:26 PDT
Created
attachment 52173
[details]
[PATCH] CRASH expectation removed
WebKit Commit Bot
Comment 5
2010-03-31 09:01:43 PDT
Comment on
attachment 52173
[details]
[PATCH] CRASH expectation removed Clearing flags on attachment: 52173 Committed
r56843
: <
http://trac.webkit.org/changeset/56843
>
WebKit Commit Bot
Comment 6
2010-03-31 09:01:48 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug