Bug 36885 - Web Inspector: [Chromium] inspector/audits-panel-functional.html crashes test_shell
Summary: Web Inspector: [Chromium] inspector/audits-panel-functional.html crashes test...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
Depends on:
Reported: 2010-03-31 07:52 PDT by Alexander Pavlov (apavlov)
Modified: 2010-03-31 09:01 PDT (History)
8 users (show)

See Also:

[PATCH] Suggested solution (2.04 KB, patch)
2010-03-31 08:00 PDT, Alexander Pavlov (apavlov)
pfeldman: review-
Details | Formatted Diff | Diff
[PATCH] Comments addressed (1.91 KB, patch)
2010-03-31 08:20 PDT, Alexander Pavlov (apavlov)
no flags Details | Formatted Diff | Diff
[PATCH] CRASH expectation removed (2.64 KB, patch)
2010-03-31 08:29 PDT, Alexander Pavlov (apavlov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2010-03-31 07:52:29 PDT
Chromium test shell crashes on inspector/audits-panel-functional.html (which works fine during pure WebKit test runs).
Comment 1 Alexander Pavlov (apavlov) 2010-03-31 08:00:53 PDT
Created attachment 52167 [details]
[PATCH] Suggested solution
Comment 2 Pavel Feldman 2010-03-31 08:15:30 PDT
Comment on attachment 52167 [details]
[PATCH] Suggested solution

> +    setTimeout(function() {evaluateInWebInspector("frontend_runAudits", callback)}, 0);
>  }

This is a hack.

> +    testController.waitUntilDone();

Every wait should have notify.

To fix your problem, do not call layoutTestController's notifyDone upon first return from the front-end.
Comment 3 Alexander Pavlov (apavlov) 2010-03-31 08:20:51 PDT
Created attachment 52171 [details]
[PATCH] Comments addressed
Comment 4 Alexander Pavlov (apavlov) 2010-03-31 08:29:26 PDT
Created attachment 52173 [details]
[PATCH] CRASH expectation removed
Comment 5 WebKit Commit Bot 2010-03-31 09:01:43 PDT
Comment on attachment 52173 [details]
[PATCH] CRASH expectation removed

Clearing flags on attachment: 52173

Committed r56843: <http://trac.webkit.org/changeset/56843>
Comment 6 WebKit Commit Bot 2010-03-31 09:01:48 PDT
All reviewed patches have been landed.  Closing bug.