Bug 36884 - Web Inspector: [REGRESSION] Can't creating new style with class foo if foo::after is defined.
Summary: Web Inspector: [REGRESSION] Can't creating new style with class foo if foo::a...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2010-03-31 07:30 PDT by Pavel Feldman
Modified: 2010-03-31 09:24 PDT (History)
4 users (show)

See Also:

[PATCH] Proposed fix. (10.65 KB, patch)
2010-03-31 07:36 PDT, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-03-31 07:30:06 PDT
Several things including usability changes and regression fixes:
- InspectorDOMAgent should clear internal state upon reset (we are re-using single dom agent instance throughout entire inspector controller lifetime) 
- Brought back blank style 'refresh' processing logic - remove it by mistake earlier
- Blocked couple of click handlers so that double-click to edit was not expanding / collapsing the pane
- There is no need to reach out for matched rules upon 'refresh' update - getting computed style is sufficient
Comment 1 Pavel Feldman 2010-03-31 07:36:21 PDT
Created attachment 52161 [details]
[PATCH] Proposed fix.

One more thing: style selector had wrong code for pseudo elements (for a long time already). It was doing return instead of continue, as a result, styles declared with pseudo modifiers were preventing subsequent styles with same classes from being returned.
Comment 2 Pavel Feldman 2010-03-31 09:24:14 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/css/CSSStyleSelector.cpp
	M	WebCore/inspector/InspectorDOMAgent.cpp
	M	WebCore/inspector/front-end/StylesSidebarPane.js
Committed r56846