Bug 36869 – [Qt] LaytoutTests/fast/canvas/fill-stroke-clip-reset-path.html failed and skipped

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Chang Shu]

Qt does not support dashboard compatibility mode. The red blocks on the 2nd row are expected. Just need to rebaseline the results.

[Chang Shu]

Created attachment 52116 [details]
fix patch

[Chang Shu]

Created attachment 52119 [details]
fix patch 2

[Laszlo Gombos]

I'd like to get more feedback on what should be the policy for tests are are testing unsupported features. 

I can see two options here:
 1./ Create a section in the skipped list for unsupported features that we do not intend to fix as a conscious decision has been made to not to support (or obsolete) a particular feature
 2./  Check in the expected failure as Chang suggested, so that we can monitor for regression going froward.

[Laszlo Gombos]

Comment on attachment 52119 [details]
fix patch 2

r+. Let's land the expected results even if the feature is not supported to catch regressions.

[WebKit Commit Bot]

Comment on attachment 52119 [details]
fix patch 2

Rejecting patch 52119 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Laszlo Gombos', '--force']" exit_code: 1
Last 500 characters of output:
ng file LayoutTests/platform/qt/Skipped
Hunk #1 FAILED at 2567.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/Skipped.rej
patching file LayoutTests/platform/qt/fast/canvas/fill-stroke-clip-reset-path-expected.checksum
patching file LayoutTests/platform/qt/fast/canvas/fill-stroke-clip-reset-path-expected.txt
error: pathspec 'LayoutTests/platform/qt/fast/canvas/fill-stroke-clip-reset-path-expected.png' did not match any file(s) known to git.
Did you forget to 'git add'?

Full output: http://webkit-commit-queue.appspot.com/results/1624148

[Chang Shu]

Merged the code and committed patch manually.

Committed revision 56911.