Bug 36869 - [Qt] LaytoutTests/fast/canvas/fill-stroke-clip-reset-path.html failed and skipped
Summary: [Qt] LaytoutTests/fast/canvas/fill-stroke-clip-reset-path.html failed and ski...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Chang Shu
Keywords: Qt
Depends on:
Reported: 2010-03-30 18:37 PDT by Chang Shu
Modified: 2010-04-01 06:51 PDT (History)
4 users (show)

See Also:

fix patch (24.17 KB, patch)
2010-03-30 18:50 PDT, Chang Shu
no flags Details | Formatted Diff | Diff
fix patch 2 (24.15 KB, patch)
2010-03-30 19:09 PDT, Chang Shu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2010-03-30 18:37:22 PDT
Qt does not support dashboard compatibility mode. The red blocks on the 2nd row are expected. Just need to rebaseline the results.
Comment 1 Chang Shu 2010-03-30 18:50:39 PDT
Created attachment 52116 [details]
fix patch
Comment 2 Chang Shu 2010-03-30 19:09:08 PDT
Created attachment 52119 [details]
fix patch 2
Comment 3 Laszlo Gombos 2010-03-31 19:29:44 PDT
I'd like to get more feedback on what should be the policy for tests are are testing unsupported features. 

I can see two options here:
 1./ Create a section in the skipped list for unsupported features that we do not intend to fix as a conscious decision has been made to not to support (or obsolete) a particular feature
 2./  Check in the expected failure as Chang suggested, so that we can monitor for regression going froward.
Comment 4 Laszlo Gombos 2010-04-01 06:13:49 PDT
Comment on attachment 52119 [details]
fix patch 2

r+. Let's land the expected results even if the feature is not supported to catch regressions.
Comment 5 WebKit Commit Bot 2010-04-01 06:25:00 PDT
Comment on attachment 52119 [details]
fix patch 2

Rejecting patch 52119 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Laszlo Gombos', '--force']" exit_code: 1
Last 500 characters of output:
ng file LayoutTests/platform/qt/Skipped
Hunk #1 FAILED at 2567.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/Skipped.rej
patching file LayoutTests/platform/qt/fast/canvas/fill-stroke-clip-reset-path-expected.checksum
patching file LayoutTests/platform/qt/fast/canvas/fill-stroke-clip-reset-path-expected.txt
error: pathspec 'LayoutTests/platform/qt/fast/canvas/fill-stroke-clip-reset-path-expected.png' did not match any file(s) known to git.
Did you forget to 'git add'?

Full output: http://webkit-commit-queue.appspot.com/results/1624148
Comment 6 Chang Shu 2010-04-01 06:51:02 PDT
Merged the code and committed patch manually.

Committed revision 56911.