Bug 36866 - Move CString to WTF
: Move CString to WTF
Status: RESOLVED FIXED
: WebKit
Platform
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-03-30 18:02 PST by
Modified: 2010-03-30 22:45 PST (History)


Attachments
The patch - do not review! (235.93 KB, patch)
2010-03-30 18:02 PST, Gavin Barraclough
no flags Review Patch | Details | Formatted Diff | Diff
Updated patch, hopefully this merges cleanly, still do not review! (235.95 KB, patch)
2010-03-30 20:20 PST, Gavin Barraclough
no flags Review Patch | Details | Formatted Diff | Diff
Reviewed by Sam, setting r? to get the buildbots to take one last sniff! (301.01 KB, patch)
2010-03-30 21:19 PST, Gavin Barraclough
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-03-30 18:02:05 PST
This should be available to all clients of WTF, and specifically will allow us to remove the redundant duplicate implementation of a C-string wrapper class from JavaScriptCore.
------- Comment #1 From 2010-03-30 18:02:58 PST -------
Created an attachment (id=52109) [details]
The patch - do not review!

Just uploading the patch to get the build bots to take a sniff at it - no ChangeLogs yet!
------- Comment #2 From 2010-03-30 18:05:23 PST -------
(From update of attachment 52109 [details])
Hmmm, looks like I may have got some screwy versions of the vcproj's in this patch, will fixerate.
------- Comment #3 From 2010-03-30 20:20:34 PST -------
Created an attachment (id=52121) [details]
Updated patch, hopefully this merges cleanly, still do not review!
------- Comment #4 From 2010-03-30 20:25:35 PST -------
Attachment 52121 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj"
File not a recognized type to check. Skipping: "WebCore/WebCore.vcproj/WebCore.vcproj"
File not a recognized type to check. Skipping: "JavaScriptCore/GNUmakefile.am"
File not a recognized type to check. Skipping: "WebCore/WebCore.pro"
WebCore/platform/cf/FileSystemCF.cpp:32:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
File not a recognized type to check. Skipping: "WebCore/Android.mk"
File not a recognized type to check. Skipping: "JavaScriptCore/Android.mk"
File not a recognized type to check. Skipping: "WebCore/WebCore.order"
JavaScriptCore/wtf/text/CString.cpp:30:  Use 'using namespace std;' instead of 'using std::min;'.  [build/using_std] [4]
WARNING: Could not read file. Skipping: "WebCore/platform/text/CString.cpp"
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebelement.cpp"
File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def"
File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.vcproj/WTF/WTF.vcproj"
File not a recognized type to check. Skipping: "WebCore/GNUmakefile.am"
File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.exp"
File not a recognized type to check. Skipping: "WebCore/WebCore.xcodeproj/project.pbxproj"
File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.gypi"
File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj"
WARNING: Could not read file. Skipping: "WebCore/platform/text/CString.h"
File not a recognized type to check. Skipping: "WebCore/WebCore.base.exp"
File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.pro"
File not a recognized type to check. Skipping: "WebCore/WebCore.gypi"
Total errors found: 2 in 254 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #5 From 2010-03-30 20:29:42 PST -------
Attachment 52121 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/1636075
------- Comment #6 From 2010-03-30 21:19:52 PST -------
Created an attachment (id=52124) [details]
Reviewed by Sam, setting r? to get the buildbots to take one last sniff!
------- Comment #7 From 2010-03-30 21:26:25 PST -------
Attachment 52124 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj"
File not a recognized type to check. Skipping: "WebCore/WebCore.vcproj/WebCore.vcproj"
File not a recognized type to check. Skipping: "JavaScriptCore/GNUmakefile.am"
File not a recognized type to check. Skipping: "WebCore/WebCore.pro"
File not a recognized type to check. Skipping: "WebCore/Android.mk"
File not a recognized type to check. Skipping: "JavaScriptCore/Android.mk"
File not a recognized type to check. Skipping: "WebCore/WebCore.order"
JavaScriptCore/wtf/text/CString.cpp:30:  Use 'using namespace std;' instead of 'using std::min;'.  [build/using_std] [4]
WARNING: Could not read file. Skipping: "WebCore/platform/text/CString.cpp"
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebelement.cpp"
File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def"
File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.vcproj/WTF/WTF.vcproj"
File not a recognized type to check. Skipping: "WebCore/GNUmakefile.am"
File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.exp"
File not a recognized type to check. Skipping: "WebCore/WebCore.xcodeproj/project.pbxproj"
File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.gypi"
File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj"
WARNING: Could not read file. Skipping: "WebCore/platform/text/CString.h"
File not a recognized type to check. Skipping: "WebCore/WebCore.base.exp"
File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.pro"
File not a recognized type to check. Skipping: "WebCore/WebCore.gypi"
Total errors found: 1 in 264 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #8 From 2010-03-30 22:45:07 PST -------
Transmitting file data ......................................................................................................................................................................................................................................................................
Committed revision 56825.
------- Comment #9 From 2010-03-30 22:45:56 PST -------
(From update of attachment 52124 [details])
Clearing review flag, rubber stamped by Sam Weinig.