This should be available to all clients of WTF, and specifically will allow us to remove the redundant duplicate implementation of a C-string wrapper class from JavaScriptCore.
Created attachment 52109 [details] The patch - do not review! Just uploading the patch to get the build bots to take a sniff at it - no ChangeLogs yet!
Comment on attachment 52109 [details] The patch - do not review! Hmmm, looks like I may have got some screwy versions of the vcproj's in this patch, will fixerate.
Created attachment 52121 [details] Updated patch, hopefully this merges cleanly, still do not review!
Attachment 52121 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj" File not a recognized type to check. Skipping: "WebCore/WebCore.vcproj/WebCore.vcproj" File not a recognized type to check. Skipping: "JavaScriptCore/GNUmakefile.am" File not a recognized type to check. Skipping: "WebCore/WebCore.pro" WebCore/platform/cf/FileSystemCF.cpp:32: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] File not a recognized type to check. Skipping: "WebCore/Android.mk" File not a recognized type to check. Skipping: "JavaScriptCore/Android.mk" File not a recognized type to check. Skipping: "WebCore/WebCore.order" JavaScriptCore/wtf/text/CString.cpp:30: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] WARNING: Could not read file. Skipping: "WebCore/platform/text/CString.cpp" WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebelement.cpp" File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def" File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.vcproj/WTF/WTF.vcproj" File not a recognized type to check. Skipping: "WebCore/GNUmakefile.am" File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.exp" File not a recognized type to check. Skipping: "WebCore/WebCore.xcodeproj/project.pbxproj" File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.gypi" File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj" WARNING: Could not read file. Skipping: "WebCore/platform/text/CString.h" File not a recognized type to check. Skipping: "WebCore/WebCore.base.exp" File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.pro" File not a recognized type to check. Skipping: "WebCore/WebCore.gypi" Total errors found: 2 in 254 files If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 52121 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/1636075
Created attachment 52124 [details] Reviewed by Sam, setting r? to get the buildbots to take one last sniff!
Attachment 52124 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj" File not a recognized type to check. Skipping: "WebCore/WebCore.vcproj/WebCore.vcproj" File not a recognized type to check. Skipping: "JavaScriptCore/GNUmakefile.am" File not a recognized type to check. Skipping: "WebCore/WebCore.pro" File not a recognized type to check. Skipping: "WebCore/Android.mk" File not a recognized type to check. Skipping: "JavaScriptCore/Android.mk" File not a recognized type to check. Skipping: "WebCore/WebCore.order" JavaScriptCore/wtf/text/CString.cpp:30: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] WARNING: Could not read file. Skipping: "WebCore/platform/text/CString.cpp" WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebelement.cpp" File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def" File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.vcproj/WTF/WTF.vcproj" File not a recognized type to check. Skipping: "WebCore/GNUmakefile.am" File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.exp" File not a recognized type to check. Skipping: "WebCore/WebCore.xcodeproj/project.pbxproj" File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.gypi" File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj" WARNING: Could not read file. Skipping: "WebCore/platform/text/CString.h" File not a recognized type to check. Skipping: "WebCore/WebCore.base.exp" File not a recognized type to check. Skipping: "JavaScriptCore/JavaScriptCore.pro" File not a recognized type to check. Skipping: "WebCore/WebCore.gypi" Total errors found: 1 in 264 files If any of these errors are false positives, please file a bug against check-webkit-style.
Transmitting file data ...................................................................................................................................................................................................................................................................... Committed revision 56825.
Comment on attachment 52124 [details] Reviewed by Sam, setting r? to get the buildbots to take one last sniff! Clearing review flag, rubber stamped by Sam Weinig.