Bug 36862 – Notifications should not resolve an empty icon parameter as a relative URL

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[John Gregg]

Currently if a notification is created with empty icon parameter, the URL will be resolved relative to the current document URL, whereas it should remain empty.

[John Gregg]

Also, this was a recent regression.

[John Gregg]

Created attachment 52099 [details]
Patch

[Dmitry Titov]

Comment on attachment 52099 [details]
Patch

> Index: WebCore/ChangeLog
> +
> +        No new tests, code is disabled in WebKit.

This looks like something that has to be covered by a test. Especially if this is a recent regression, as you say in the bug. The ENABLE_NOTIFICATIONS is enabled in Chromium, so perhaps there is a way to have a test running at least in chromium port?

Removing r? for now, feel free to flip back if there is a test or if it is plain impossible to have one.

[John Gregg]

Created attachment 52468 [details]
Patch

[John Gregg]

Okay, I'm adding a test for this.  All the notifications tests are disabled on all platforms pending patches to add the necessary hooks in DumpRenderTree/test_shell, so I'll add this one disabled as well.  

I have the testing hooks mostly done and can push that through soon, but since this is a regression it would be nice if we could land it with the placeholder test for now.

[WebKit Commit Bot]

Comment on attachment 52468 [details]
Patch

Rejecting patch 52468 from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact [e-mail] to request a commit-queue restart.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 52468 [details]
Patch

Clearing flags on attachment: 52468

Committed r57103: <http://trac.webkit.org/changeset/57103>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.