Bug 36860 - Updating Chromium media baselines and expectations
Summary: Updating Chromium media baselines and expectations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-30 16:09 PDT by Andrew Scherkus
Modified: 2010-03-31 17:17 PDT (History)
2 users (show)

See Also:

Attachments
2010-03-30 Andrew Scherkus <scherkus@chromium.org> (5.59 KB, patch)
2010-03-30 16:12 PDT, Andrew Scherkus 		no flags Details | Formatted Diff | Diff
2010-03-31 Andrew Scherkus <scherkus@chromium.org> (47.09 KB, patch)
2010-03-31 12:10 PDT, Andrew Scherkus 		no flags Details | Formatted Diff | Diff
2010-03-31 Andrew Scherkus <scherkus@chromium.org> (45.56 KB, patch)
2010-03-31 15:14 PDT, Andrew Scherkus 		dimich: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Scherkus 2010-03-30 16:09:13 PDT 
With r56481 landed Chromium can now pass those layout tests.
Comment 1 Andrew Scherkus 2010-03-30 16:12:11 PDT 
Created attachment 52094 [details]
2010-03-30  Andrew Scherkus  <scherkus@chromium.org>
Comment 2 Andrew Scherkus 2010-03-30 17:18:28 PDT 
Comment on attachment 52094 [details]
2010-03-30  Andrew Scherkus  <scherkus@chromium.org>

This isn't ready to review just yet.
Comment 3 Andrew Scherkus 2010-03-31 12:10:34 PDT 
Created attachment 52193 [details]
2010-03-31  Andrew Scherkus  <scherkus@chromium.org>
Comment 4 Dmitry Titov 2010-03-31 12:47:03 PDT 
media/audio-constructor-src.html seems to have the same baseline here for win and mac, does it actually need a platform-specific baseline?

Same question for media/video-source-add-src.html.

If the test does not run on Linux, we might disable it in test_expectations for Linux and have one shared result.
Comment 5 Dmitry Titov 2010-03-31 14:31:54 PDT 
Comment on attachment 52193 [details]
2010-03-31  Andrew Scherkus  <scherkus@chromium.org>

Per offline discussion, Andrew is going to update the patch. removing the r? flag to temporarily move the patch out of the queue.
Comment 6 Andrew Scherkus 2010-03-31 15:14:06 PDT 
Created attachment 52215 [details]
2010-03-31  Andrew Scherkus  <scherkus@chromium.org>
Comment 7 Dmitry Titov 2010-03-31 15:19:13 PDT 
Comment on attachment 52215 [details]
2010-03-31  Andrew Scherkus  <scherkus@chromium.org>

r=me
Comment 8 Andrew Scherkus 2010-03-31 15:54:39 PDT 
Committed as http://trac.webkit.org/changeset/56873
Comment 9 Eric Seidel (no email) 2010-03-31 17:17:08 PDT 
Looks like fast/workers/worker-terminate.html, http/tests/misc/image-blocked-src-change.html have been failing since this change on the Gtk 32 bit Debug builder:
http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Debug