webkit-patch what-broke throws exception
missing import of StringIO in api.py
Created attachment 52081 [details]
This is probably what caused sheriffbot to fail to report the recent break from ap.
Comment on attachment 52081 [details]
Committed r56809: <http://trac.webkit.org/changeset/56809>
Committed r56828: <http://trac.webkit.org/changeset/56828>
(In reply to comment #6)
No problem. Ah, I thought it is 4am in your timezone so I didn't ask a review. It turned out the clock in my office was broken...
Oh, reviews are never necessary for "build" fixes like this one. Thanks again for cleaning up my mess!
(In reply to comment #8)
> Oh, reviews are never necessary for "build" fixes like this one. Thanks again
> for cleaning up my mess!
Yeah, usually I land trivial fixes without reviews. But in this case, I wasn't 100% sure if my fix meets your intention so I wanted ask you to check if possible.
Anyway, we fixed our clocks, too :)