RESOLVED FIXED Bug 36852
webkit-patch what-broke throws exception 
https://bugs.webkit.org/show_bug.cgi?id=36852
Summary webkit-patch what-broke throws exception
Eric Seidel (no email)
Reported 2010-03-30 14:14:21 PDT
webkit-patch what-broke throws exception missing import of StringIO in api.py
Attachments
Patch (4.18 KB, patch)
2010-03-30 14:16 PDT, Eric Seidel (no email) 		abarth: review+
eric: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-03-30 14:16:38 PDT
Created attachment 52081 [details] Patch
Eric Seidel (no email)
Comment 2 2010-03-30 14:17:13 PDT
This is probably what caused sheriffbot to fail to report the recent break from ap.
Adam Barth
Comment 3 2010-03-30 14:27:59 PDT
Comment on attachment 52081 [details] Patch thanks
Eric Seidel (no email)
Comment 4 2010-03-30 14:44:53 PDT
Committed r56809: <http://trac.webkit.org/changeset/56809>
Shinichiro Hamaji
Comment 5 2010-03-31 00:15:00 PDT
Committed r56828: <http://trac.webkit.org/changeset/56828>
Eric Seidel (no email)
Comment 6 2010-03-31 00:16:15 PDT
Thanks!
Shinichiro Hamaji
Comment 7 2010-03-31 00:20:46 PDT
(In reply to comment #6) > Thanks! No problem. Ah, I thought it is 4am in your timezone so I didn't ask a review. It turned out the clock in my office was broken...
Eric Seidel (no email)
Comment 8 2010-03-31 00:26:38 PDT
Oh, reviews are never necessary for "build" fixes like this one. Thanks again for cleaning up my mess!
Shinichiro Hamaji
Comment 9 2010-03-31 01:35:11 PDT
(In reply to comment #8) > Oh, reviews are never necessary for "build" fixes like this one. Thanks again > for cleaning up my mess! Yeah, usually I land trivial fixes without reviews. But in this case, I wasn't 100% sure if my fix meets your intention so I wanted ask you to check if possible. Anyway, we fixed our clocks, too :)
Note You need to log in before you can comment on or make changes to this bug.