Bug 36852 - webkit-patch what-broke throws exception
Summary: webkit-patch what-broke throws exception
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-30 14:14 PDT by Eric Seidel (no email)
Modified: 2010-04-02 11:51 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.18 KB, patch)
2010-03-30 14:16 PDT, Eric Seidel (no email) 		abarth: review+
eric: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-03-30 14:14:21 PDT 
webkit-patch what-broke throws exception

missing import of StringIO in api.py
Comment 1 Eric Seidel (no email) 2010-03-30 14:16:38 PDT 
Created attachment 52081 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-03-30 14:17:13 PDT 
This is probably what caused sheriffbot to fail to report the recent break from ap.
Comment 3 Adam Barth 2010-03-30 14:27:59 PDT 
Comment on attachment 52081 [details]
Patch

thanks
Comment 4 Eric Seidel (no email) 2010-03-30 14:44:53 PDT 
Committed r56809: <http://trac.webkit.org/changeset/56809>
Comment 5 Shinichiro Hamaji 2010-03-31 00:15:00 PDT 
Committed r56828: <http://trac.webkit.org/changeset/56828>
Comment 6 Eric Seidel (no email) 2010-03-31 00:16:15 PDT 
Thanks!
Comment 7 Shinichiro Hamaji 2010-03-31 00:20:46 PDT 
(In reply to comment #6)
> Thanks!

No problem. Ah, I thought it is 4am in your timezone so I didn't ask a review. It turned out the clock in my office was broken...
Comment 8 Eric Seidel (no email) 2010-03-31 00:26:38 PDT 
Oh, reviews are never necessary for "build" fixes like this one.  Thanks again for cleaning up my mess!
Comment 9 Shinichiro Hamaji 2010-03-31 01:35:11 PDT 
(In reply to comment #8)
> Oh, reviews are never necessary for "build" fixes like this one.  Thanks again
> for cleaning up my mess!

Yeah, usually I land trivial fixes without reviews. But in this case, I wasn't 100% sure if my fix meets your intention so I wanted ask you to check if possible.

Anyway, we fixed our clocks, too :)