Bug 36847 – Add new worker-specific tests for the async DB

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Eric U.]

In addition to the existing async DB tests, which are being ported to Web Workers, there are some new tests that should be added.  In particular, we should test simultaneous accesses from the page and the worker, and from multiple workers, and we should test shutting down a worker during database access.  These tests will be racy themselves, but should at least verify that we don't crash or corrupt anything.

[Dumitru Daniliuc]

I'll take this bug. I've already added 2 tests that shut down workers while they access the database. So I'll work on adding some tests that access the same DB in the page and on multiple workers at the same time.

[Dumitru Daniliuc]

Created attachment 69424 [details]
patch #1: access the same DB in workers and the page

[Dumitru Daniliuc]

Created attachment 69425 [details]
patch #2: terminate workers in the middle of DB operations

These tests were initially added in http://trac.webkit.org/changeset/64313. Then that patch got reverted in http://trac.webkit.org/changeset/64334, because of a bug. Then the bug was fixed, and the patch was re-landed in http://trac.webkit.org/changeset/64384, but apparently I forgot to re-submit the tests.

[David Levin]

Comment on attachment 69424 [details]
patch #1: access the same DB in workers and the page

View in context: https://bugs.webkit.org/attachment.cgi?id=69424&action=review

> LayoutTests/fast/workers/storage/use-same-database-in-page-and-workers.html:49
> +                log("Unexpected worker message: " + event.data);

It seems like it would be better if it didn't have to time out on failure.

[Dumitru Daniliuc]

Created attachment 69427 [details]
patch #1: access the same DB in workers and the page

fixed.

[Dumitru Daniliuc]

patch #1 landed: r69626.
patch #2 landed: r69631.