Bug 36847 - Add new worker-specific tests for the async DB
Summary: Add new worker-specific tests for the async DB
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Dumitru Daniliuc
URL:
Keywords:
Depends on: 34992
Blocks: 34990
  Show dependency tree / graph
 
Reported: 2010-03-30 13:10 PDT by Eric U.
Modified: 2010-10-12 18:48 PDT (History)
3 users (show)

See Also:

Attachments
patch #1: access the same DB in workers and the page (4.67 KB, patch)
2010-09-30 23:07 PDT, Dumitru Daniliuc 		levin: review-
dumi: commit-queue-
Details | Formatted Diff | Diff
patch #2: terminate workers in the middle of DB operations (6.50 KB, patch)
2010-09-30 23:16 PDT, Dumitru Daniliuc 		levin: review+
dumi: commit-queue-
Details | Formatted Diff | Diff
patch #1: access the same DB in workers and the page (4.70 KB, patch)
2010-09-30 23:41 PDT, Dumitru Daniliuc 		levin: review+
dumi: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric U. 2010-03-30 13:10:50 PDT 
In addition to the existing async DB tests, which are being ported to Web Workers, there are some new tests that should be added.  In particular, we should test simultaneous accesses from the page and the worker, and from multiple workers, and we should test shutting down a worker during database access.  These tests will be racy themselves, but should at least verify that we don't crash or corrupt anything.
Comment 1 Dumitru Daniliuc 2010-07-29 15:35:32 PDT 
I'll take this bug. I've already added 2 tests that shut down workers while they access the database. So I'll work on adding some tests that access the same DB in the page and on multiple workers at the same time.
Comment 2 Dumitru Daniliuc 2010-09-30 23:07:16 PDT 
Created attachment 69424 [details]
patch #1: access the same DB in workers and the page
Comment 3 Dumitru Daniliuc 2010-09-30 23:16:41 PDT 
Created attachment 69425 [details]
patch #2: terminate workers in the middle of DB operations

These tests were initially added in http://trac.webkit.org/changeset/64313. Then that patch got reverted in http://trac.webkit.org/changeset/64334, because of a bug. Then the bug was fixed, and the patch was re-landed in http://trac.webkit.org/changeset/64384, but apparently I forgot to re-submit the tests.
Comment 4 David Levin 2010-09-30 23:32:08 PDT 
Comment on attachment 69424 [details]
patch #1: access the same DB in workers and the page

View in context: https://bugs.webkit.org/attachment.cgi?id=69424&action=review

> LayoutTests/fast/workers/storage/use-same-database-in-page-and-workers.html:49
> +                log("Unexpected worker message: " + event.data);

It seems like it would be better if it didn't have to time out on failure.
Comment 5 Dumitru Daniliuc 2010-09-30 23:41:46 PDT 
Created attachment 69427 [details]
patch #1: access the same DB in workers and the page

fixed.
Comment 6 Dumitru Daniliuc 2010-10-12 18:48:32 PDT 
patch #1 landed: r69626.
patch #2 landed: r69631.