WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
36828
Web Inspector: get rid of "Unsafe JavaScript attempt..." message when inspecting frames whose content has changed
https://bugs.webkit.org/show_bug.cgi?id=36828
Summary
Web Inspector: get rid of "Unsafe JavaScript attempt..." message when inspect...
Yury Semikhatsky
Reported
2010-03-30 08:37:48 PDT
Run LayoutTests/http/tests/inspector-enabled/console-log-before-frame-navigation.html It will write following message in console: Unsafe JavaScript attempt to access frame with URL
http://localhost:8000/inspector-enabled/resources/console-log-frame-after-navigation.html
from frame with URL
http://127.0.0.1:8000/inspector-enabled/resources/console-log-frame-before-navigation.html
. Domains, protocols and ports must match.
Attachments
patch
(9.79 KB, patch)
2010-03-30 08:44 PDT
,
Yury Semikhatsky
pfeldman
: review-
Details
Formatted Diff
Diff
patch
(8.08 KB, patch)
2010-03-31 07:31 PDT
,
Yury Semikhatsky
no flags
Details
Formatted Diff
Diff
patch
(9.53 KB, patch)
2010-03-31 07:55 PDT
,
Yury Semikhatsky
no flags
Details
Formatted Diff
Diff
patch
(10.59 KB, patch)
2010-03-31 08:05 PDT
,
Yury Semikhatsky
pfeldman
: review+
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1
2010-03-30 08:44:14 PDT
Created
attachment 52042
[details]
patch
WebKit Review Bot
Comment 2
2010-03-30 08:48:29 PDT
Attachment 52042
[details]
did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp:47: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3
2010-03-30 08:49:18 PDT
Attachment 52042
[details]
did not build on qt: Build output:
http://webkit-commit-queue.appspot.com/results/1629100
Eric Seidel (no email)
Comment 4
2010-03-30 08:51:09 PDT
Attachment 52042
[details]
did not build on mac: Build output:
http://webkit-commit-queue.appspot.com/results/1584090
Pavel Feldman
Comment 5
2010-03-30 08:54:57 PDT
Comment on
attachment 52042
[details]
patch I don't think we should add such a complexity because of a corner case scenario. I'd much rather not get into InjectedScript bindings from native code if we know that inspected window is no longer available.
Yury Semikhatsky
Comment 6
2010-03-31 07:31:14 PDT
Created
attachment 52159
[details]
patch
WebKit Review Bot
Comment 7
2010-03-31 07:35:52 PDT
Attachment 52159
[details]
did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp:47: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 8
2010-03-31 07:36:46 PDT
Attachment 52159
[details]
did not build on qt: Build output:
http://webkit-commit-queue.appspot.com/results/1628127
Eric Seidel (no email)
Comment 9
2010-03-31 07:38:11 PDT
Attachment 52159
[details]
did not build on mac: Build output:
http://webkit-commit-queue.appspot.com/results/1629134
Yury Semikhatsky
Comment 10
2010-03-31 07:55:15 PDT
Created
attachment 52166
[details]
patch Fixed release mode build errors.
Eric Seidel (no email)
Comment 11
2010-03-31 07:57:34 PDT
Attachment 52166
[details]
did not build on mac: Build output:
http://webkit-commit-queue.appspot.com/results/1597096
Early Warning System Bot
Comment 12
2010-03-31 08:04:09 PDT
Attachment 52166
[details]
did not build on qt: Build output:
http://webkit-commit-queue.appspot.com/results/1604133
Yury Semikhatsky
Comment 13
2010-03-31 08:05:47 PDT
Created
attachment 52168
[details]
patch One more attempt to fix release mode builds.
Pavel Feldman
Comment 14
2010-03-31 08:17:54 PDT
Comment on
attachment 52168
[details]
patch Fix ChangeLog, otherwise looks good.
Yury Semikhatsky
Comment 15
2010-03-31 08:24:54 PDT
Committing to
http://svn.webkit.org/repository/webkit/trunk
... M LayoutTests/ChangeLog M LayoutTests/http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt M LayoutTests/http/tests/inspector-enabled/resources/console-log-frame-before-navigation.html M WebCore/ChangeLog M WebCore/bindings/js/JSInjectedScriptHostCustom.cpp M WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp M WebCore/inspector/InjectedScript.cpp M WebCore/inspector/InjectedScript.h M WebCore/inspector/InjectedScriptHost.h M WebCore/inspector/front-end/InjectedScript.js Committed
r56841
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug