Bug 36828 – Web Inspector: get rid of "Unsafe JavaScript attempt..." message when inspecting frames whose content has changed

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

Run LayoutTests/http/tests/inspector-enabled/console-log-before-frame-navigation.html
It will write following message in console:

Unsafe JavaScript attempt to access frame with URL http://localhost:8000/inspector-enabled/resources/console-log-frame-after-navigation.html from frame with URL http://127.0.0.1:8000/inspector-enabled/resources/console-log-frame-before-navigation.html. Domains, protocols and ports must match.

[Yury Semikhatsky]

Created attachment 52042 [details]
patch

[WebKit Review Bot]

Attachment 52042 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp:47:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Attachment 52042 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/1629100

[Eric Seidel (no email)]

Attachment 52042 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/1584090

[Pavel Feldman]

Comment on attachment 52042 [details]
patch

I don't think we should add such a complexity because of a corner case scenario. I'd much rather not get into InjectedScript bindings from native code if we know that inspected window is no longer available.

[Yury Semikhatsky]

Created attachment 52159 [details]
patch

[WebKit Review Bot]

Attachment 52159 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp:47:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Attachment 52159 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/1628127

[Eric Seidel (no email)]

Attachment 52159 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/1629134

[Yury Semikhatsky]

Created attachment 52166 [details]
patch

Fixed release mode build errors.

[Eric Seidel (no email)]

Attachment 52166 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/1597096

[Early Warning System Bot]

Attachment 52166 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/1604133

[Yury Semikhatsky]

Created attachment 52168 [details]
patch

One more attempt to fix release mode builds.

[Pavel Feldman]

Comment on attachment 52168 [details]
patch

Fix ChangeLog, otherwise looks good.

[Yury Semikhatsky]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt
	M	LayoutTests/http/tests/inspector-enabled/resources/console-log-frame-before-navigation.html
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/JSInjectedScriptHostCustom.cpp
	M	WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp
	M	WebCore/inspector/InjectedScript.cpp
	M	WebCore/inspector/InjectedScript.h
	M	WebCore/inspector/InjectedScriptHost.h
	M	WebCore/inspector/front-end/InjectedScript.js
Committed r56841