Bug 36824 – [Chromium] rebaseline_chromium_webkit_test raises an exception

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Shinichiro Hamaji]

% ./third_party/WebKit/WebKitTools/Scripts/rebaseline-chromium-webkit-tests
100330 04:40:16 rebaseline_chromium_webkit_tests.py:169 INFO Html directory: "/tmp/tmpISc0vA/rebaseline_html"
100330 04:40:17 rebaseline_chromium_webkit_tests.py:1034 INFO
100330 04:40:17 rebaseline_chromium_webkit_tests.py:147 INFO --------------------------- Rebaseline started: mac ---------------------------
100330 04:40:17 rebaseline_chromium_webkit_tests.py:147 INFO ---------------------- Compiling rebaselining tests: mac ----------------------
100330 04:40:17 rebaseline_chromium_webkit_tests.py:298 INFO Total number of tests needing rebaselining for "mac": "1"
100330 04:40:17 rebaseline_chromium_webkit_tests.py:302 INFO   1: fast/repaint/overflow-scroll-body-appear.html
100330 04:40:17 rebaseline_chromium_webkit_tests.py:147 INFO --------------------------- Downloading archive: mac ---------------------------
100330 04:40:18 rebaseline_chromium_webkit_tests.py:330 INFO Latest revision: "43070"
100330 04:40:18 rebaseline_chromium_webkit_tests.py:372 INFO Archive url: "http://build.chromium.org/buildbot/layout_test_results/webkit-rel-mac5/43070/layout-test-results.zip"
100330 04:40:24 rebaseline_chromium_webkit_tests.py:388 INFO Archive downloaded and saved to file: "/tmp/tmpoZhayo.zip"
100330 04:40:24 rebaseline_chromium_webkit_tests.py:241 INFO
100330 04:40:24 rebaseline_chromium_webkit_tests.py:147 INFO ------------------- Extracting and adding new baselines: mac -------------------
100330 04:40:24 rebaseline_chromium_webkit_tests.py:416 INFO Test 1: fast/repaint/overflow-scroll-body-appear.html
100330 04:40:24 rebaseline_chromium_webkit_tests.py:427 INFO   .txt file not in archive.
100330 04:40:24 rebaseline_chromium_webkit_tests.py:431 INFO   .png file found in archive.
Traceback (most recent call last):
  File "./third_party/WebKit/WebKitTools/Scripts/rebaseline-chromium-webkit-tests", line 44, in <module>
    rebaseline_chromium_webkit_tests.main()
  File "/Users/hamaji/gitchr/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py", line 1036, in main
    if rebaseliner.run(backup):
  File "/Users/hamaji/gitchr/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py", line 248, in run
    if not self._extract_and_add_new_baselines(archive_file):
  File "/Users/hamaji/gitchr/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py", line 442, in _extract_and_add_new_baselines
    self._port.baseline_path(platform), expected_filename)
TypeError: baseline_path() takes exactly 1 argument (2 given)

[Shinichiro Hamaji]

Created attachment 52036 [details]
Patch v1

[Eric Seidel (no email)]

Comment on attachment 52036 [details]
Patch v1

OK.  Normally we write tests every time we find a break like this.  Is it possible to write a test here?

test-webkitpy is how we run the tests.  it automatically searches for any files named *_unittest.py and imports all classes it contains and runs any tests it finds using python's built in unittest library.

[Eric Seidel (no email)]

"we" meaning "adam and I" (the folks who have been writing webkitpy which rebaseline.py is now a part of for better or worse).  I'm OK with accepting this on the grounds of "it's already tested by just running it", but I find that testing stuff like this makes refactoring much easier in the future.

[David Levin]

Comment on attachment 52036 [details]
Patch v1

This looks good. It looks like Alpha thought so too (because he basically committed this after I pointed it out: http://trac.webkit.org/changeset/56817).

[David Levin]

Committed as http://trac.webkit.org/changeset/56817