WebKit/chromium/src/WebDevToolsFrontendImpl.cpp provides Chromium-specific implementation for InspectorFrontendHost(look at WebDevToolsFrontendImpl constructor). Most of the code can be generated and the rest should reside in bindings layer.
Created attachment 52406 [details] patch
Comment on attachment 52406 [details] patch Could you merge WebDevToolsFrontendImpl and InspectorFrontendClientImpl? I realize there is a life time clash, but I think we should fix this! > + > + Implement InspectorFrontendHost::showContextMenu for v8. Use Web Inspector prefix. > > +#include "V8MouseEvent.h" > #include "V8Binding.h" Mind alphabetic order.
(In reply to comment #2) > (From update of attachment 52406 [details]) > Could you merge WebDevToolsFrontendImpl and InspectorFrontendClientImpl? I > realize there is a life time clash, but I think we should fix this! > Filed bug on this: https://bugs.webkit.org/show_bug.cgi?id=37021 > > > + > > + Implement InspectorFrontendHost::showContextMenu for v8. > > Use Web Inspector prefix. > Done. > > > > +#include "V8MouseEvent.h" > > #include "V8Binding.h" > > Mind alphabetic order. Done.
Created attachment 52409 [details] patch that I'm going to land
Committing to http://svn.webkit.org/repository/webkit/trunk ... C WebCore/inspector/InspectorFrontendClientLocal.h => WebKit/chromium/src/InspectorFrontendClientImpl.h M WebCore/ChangeLog M WebCore/WebCore.Inspector.exp M WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp M WebCore/inspector/InspectorFrontendClient.h M WebCore/inspector/InspectorFrontendClientLocal.cpp M WebCore/inspector/InspectorFrontendClientLocal.h M WebCore/inspector/InspectorFrontendHost.cpp M WebCore/inspector/InspectorFrontendHost.h M WebKit/chromium/ChangeLog M WebKit/chromium/WebKit.gyp A WebKit/chromium/src/InspectorFrontendClientImpl.cpp M WebKit/chromium/src/WebDevToolsFrontendImpl.cpp M WebKit/chromium/src/WebDevToolsFrontendImpl.h M WebKit/chromium/src/js/DebuggerAgent.js M WebKit/chromium/src/js/DevTools.js Committed r56999