Bug 36814 - [DRT/Chromium] Add TestShell and WebViewHost class, main(), and so on
Summary: [DRT/Chromium] Add TestShell and WebViewHost class, main(), and so on
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 35902
  Show dependency treegraph
 
Reported: 2010-03-30 02:51 PDT by Kent Tamura
Modified: 2010-04-01 20:37 PDT (History)
2 users (show)

See Also:


Attachments
Proposed patch (95.54 KB, patch)
2010-03-30 03:04 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-03-30 02:51:07 PDT
[DRT/Chromium] Add TestShell and WebViewHost class, main(), and so on
Comment 1 Kent Tamura 2010-03-30 03:04:52 PDT
Created attachment 52019 [details]
Proposed patch
Comment 2 WebKit Review Bot 2010-03-30 03:07:12 PDT
Attachment 52019 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/DumpRenderTree/chromium/config.h:38:  Streams are highly discouraged.  [readability/streams] [3]
WebKitTools/DumpRenderTree/chromium/DumpRenderTree.cpp:33:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kent Tamura 2010-03-30 03:12:13 PDT
Sorry for the very huge patch.
These files are related to each other strongly.

(In reply to comment #2)
> WebKitTools/DumpRenderTree/chromium/config.h:38:  Streams are highly
> discouraged.  [readability/streams] [3]
> WebKitTools/DumpRenderTree/chromium/DumpRenderTree.cpp:33:  Found other header
> before a header this file implements. Should be: config.h, primary header,
> blank line, and then alphabetically sorted.  [build/include_order] [4]
> Total errors found: 2 in 8 files

These style errors are expected, and I think we can't avoid them.
Comment 4 Dimitri Glazkov (Google) 2010-04-01 08:47:31 PDT
Comment on attachment 52019 [details]
Proposed patch

ok. I apologize for the delay. This is a bit rubberstampish (patch is huge), because I know we have to land something in order to enable us to work on it together.
Comment 5 Kent Tamura 2010-04-01 20:37:41 PDT
Comment on attachment 52019 [details]
Proposed patch

Clearing flags on attachment: 52019

Committed r56963: <http://trac.webkit.org/changeset/56963>
Comment 6 Kent Tamura 2010-04-01 20:37:53 PDT
All reviewed patches have been landed.  Closing bug.