Bug 36804 – NULL pointer crash if XSLT @import fails

• Status: RESOLVED
• Resolution: FIXED
• Component: XML

[Chris Evans]

This came in as a Chromium security bug, but on analysis appears to be harmless fixed-offset NULL pointer error: http://code.google.com/p/chromium/issues/detail?id=39433

Nevertheless, we are seeing evidence of some real sites being impacted as a stability bug, e.g. www.fotka.pl, so I decided to just fix it. (Likely, there is a crash every time a network or server error gets in the way of an @import load).

Patch forthcoming.

[Chris Evans]

Created attachment 51999 [details]
Fix NULL ptr deref

[WebKit Review Bot]

Attachment 51999 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/xml/XSLStyleSheetLibxslt.cpp:158:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Evans]

Created attachment 52000 [details]
Fix style-bot issue.

[Alexey Proskuryakov]

Comment on attachment 52000 [details]
Fix style-bot issue.

r=me, looks great.

[WebKit Commit Bot]

Comment on attachment 52000 [details]
Fix style-bot issue.

Rejecting patch 52000 from commit-queue.

Unexpected failure when landing patch!  Please file a bug against webkit-patch.
Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--build-style=both', '--quiet', '52000', '--no-update']" exit_code: 1
Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=52000&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=36804&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Processing patch 52000 from bug 36804.
ERROR: LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

[Eric Seidel (no email)]

You removed the Reviewed By line from your LayoutTEsts changelog.  That caused the failure.

[Chris Evans]

Created attachment 52337 [details]
Fix missing Reviewed by NOBODY line.

[Chris Evans]

Oops. Eric / Adam, could you toss it back on the commit queue?

[Adam Barth]

Comment on attachment 52337 [details]
Fix missing Reviewed by NOBODY line.

Forwarding ap's r+.

[WebKit Commit Bot]

Comment on attachment 52337 [details]
Fix missing Reviewed by NOBODY line.

Clearing flags on attachment: 52337

Committed r56956: <http://trac.webkit.org/changeset/56956>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.