Bug 36803 - 'Inline-table' workaround for <ruby> broken with ruby support
Summary: 'Inline-table' workaround for <ruby> broken with ruby support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P1 Major
Assignee: Roland Steiner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-29 21:02 PDT by Roland Steiner
Modified: 2010-03-31 21:14 PDT (History)
1 user (show)

See Also:


Attachments
patch - use ruby rendering only if 'display' hasn't been altered (7.12 KB, patch)
2010-03-29 22:08 PDT, Roland Steiner
darin: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2010-03-29 21:02:45 PDT
As described in the Chromium bug comment at http://code.google.com/p/chromium/issues/detail?id=27659#c3 it seems that the ruby support as implemented broke the CSS 'inline-table' workaround for ruby used by some sites (e.g., http://grammar.nihongoresources.com).
Comment 1 Roland Steiner 2010-03-29 22:08:24 PDT
Created attachment 52003 [details]
patch - use ruby rendering only if 'display' hasn't been altered

Patch: Instantiate ruby renderers only if 'display' value is either 'inline' or 'block'. Don't use ruby renderers for other display values such as 'inline-table'.
Comment 2 WebKit Commit Bot 2010-03-31 00:32:20 PDT
Comment on attachment 52003 [details]
patch - use ruby rendering only if 'display' hasn't been altered

Rejecting patch 52003 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Darin Adler', '--force']" exit_code: 2
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/fast/ruby/ruby-inline-table.html
patching file LayoutTests/platform/mac/fast/ruby/ruby-inline-table-expected.checksum
patch: **** Only garbage was found in the patch input.
patching file LayoutTests/platform/mac/fast/ruby/ruby-inline-table-expected.txt
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/rendering/RenderObject.cpp

Full output: http://webkit-commit-queue.appspot.com/results/1581103
Comment 3 Roland Steiner 2010-03-31 21:14:21 PDT
Landed as rev. 56890.