Bug 36799 - [chromium] Many new test results are needed due to recent check-ins.
Summary: [chromium] Many new test results are needed due to recent check-ins.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-29 19:15 PDT by David Levin
Modified: 2010-04-08 15:23 PDT (History)
5 users (show)

See Also:


Attachments
Proposed fix. (894.49 KB, patch)
2010-03-29 19:18 PDT, David Levin
no flags Details | Formatted Diff | Diff
Proposed fix. (261.46 KB, patch)
2010-03-29 22:25 PDT, David Levin
levin: review-
Details | Formatted Diff | Diff
Proposed fix (part 2). (260.44 KB, patch)
2010-03-29 23:27 PDT, David Levin
no flags Details | Formatted Diff | Diff
Proposed fix (part 3). (39.72 KB, patch)
2010-03-30 00:10 PDT, David Levin
no flags Details | Formatted Diff | Diff
Partial rollout: mozilla- and mozilla_expected_failures tests (106.30 KB, patch)
2010-04-08 13:18 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Rollout 56771 (24.54 KB, patch)
2010-04-08 13:35 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (688.26 KB, patch)
2010-04-08 13:55 PDT, Ojan Vafai
dbates: review+
Details | Formatted Diff | Diff
Patch (463.26 KB, patch)
2010-04-08 14:43 PDT, Ojan Vafai
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2010-03-29 19:15:11 PDT
There were several check-ins recently that changed pixel results or added new tests which fail for chromium, so this bug is about handling all of those.
Comment 1 David Levin 2010-03-29 19:18:35 PDT
Created attachment 51995 [details]
Proposed fix.
Comment 2 Dimitri Glazkov (Google) 2010-03-29 19:32:12 PDT
Comment on attachment 51995 [details]
Proposed fix.

ok.
Comment 3 David Levin 2010-03-29 19:46:20 PDT
Comment on attachment 51995 [details]
Proposed fix.

Clearing r+ due to landing this as http://trac.webkit.org/changeset/56758

(Not resolving the bug yet because there are likely some more rebaselines needed.)
Comment 4 David Levin 2010-03-29 22:25:06 PDT
Created attachment 52004 [details]
Proposed fix.
Comment 5 David Levin 2010-03-29 22:52:49 PDT
Comment on attachment 52004 [details]
Proposed fix.

Due to bad inspector baseline.
Comment 6 David Levin 2010-03-29 23:27:39 PDT
Created attachment 52006 [details]
Proposed fix (part 2).
Comment 7 Shinichiro Hamaji 2010-03-29 23:38:53 PDT
Comment on attachment 52006 [details]
Proposed fix (part 2).

LGTM!
Comment 8 David Levin 2010-03-29 23:45:15 PDT
Comment on attachment 52006 [details]
Proposed fix (part 2).

Clearing r+. Committed as http://trac.webkit.org/changeset/56766
Comment 9 David Levin 2010-03-30 00:10:18 PDT
Created attachment 52008 [details]
Proposed fix (part 3).

Hopefully the last one. I missed this change last time.
Comment 10 Adam Barth 2010-03-30 00:21:03 PDT
Comment on attachment 52008 [details]
Proposed fix (part 3).

ok.  we need to automate this.
Comment 11 David Levin 2010-03-30 00:25:28 PDT
Should be completely fixed now: http://trac.webkit.org/changeset/56771
Comment 12 Daniel Bates 2010-04-08 12:56:16 PDT
We decided to rollout the patch for bug #9268 (committed in change set 56655, <http://trac.webkit.org/changeset/57287>) since it caused regressions in some of the mozilla- and mozilla expected failure- tests. See bug #9268 for more details.
Comment 13 Daniel Bates 2010-04-08 13:18:44 PDT
Created attachment 52888 [details]
Partial rollout: mozilla- and mozilla_expected_failures tests

Partial rollout of 56766.

Patch to roll out the changes to the mozilla- and mozilla_expected_failures- tests committed in change set 56766 since we rolled out the change committed in change set 56655, <http://trac.webkit.org/changeset/56655> (in change set 57287, <http://trac.webkit.org/changeset/57287>). See bug #9268 for more details.
Comment 14 Daniel Bates 2010-04-08 13:35:54 PDT
Created attachment 52891 [details]
Rollout 56771

Rollout change set 56771 since we rolled out the change committed in change set 56655, <http://trac.webkit.org/changeset/56655> (in change set 57287, <http://trac.webkit.org/changeset/57287>). See bug #9268 for more details.
Comment 15 Ojan Vafai 2010-04-08 13:55:30 PDT
Created attachment 52893 [details]
Patch
Comment 16 Daniel Bates 2010-04-08 14:06:53 PDT
Comment on attachment 52893 [details]
Patch


> +        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
> +        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
> +        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
> +        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
> +        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
> +        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
> +        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
> +        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:

I take it you have confirmed these also regressed.

Looks sane to me otherwise.

r=me
Comment 17 Ojan Vafai 2010-04-08 14:09:38 PDT
Committed r57291: <http://trac.webkit.org/changeset/57291>
Comment 18 Ojan Vafai 2010-04-08 14:43:25 PDT
Created attachment 52897 [details]
Patch
Comment 19 Dimitri Glazkov (Google) 2010-04-08 14:44:54 PDT
Comment on attachment 52897 [details]
Patch

ok.
Comment 20 Ojan Vafai 2010-04-08 14:49:02 PDT
Committed r57293: <http://trac.webkit.org/changeset/57293>
Comment 21 WebKit Review Bot 2010-04-08 15:23:30 PDT
http://trac.webkit.org/changeset/57293 might have broken SnowLeopard Intel Release (Tests)