With the following HTML: <!DOCTYPE html> <span style="outline: solid red 5px"><br><span> the outline around the span has a non-rectangular top and bottom. It sort of looks like we're not generating enough strokes for very narrow outlines.
Created attachment 51984 [details] Test cases We do not match Firefox 3.6's rendering exactly on any of these four cases.
Created attachment 97392 [details] Patch Patch
Comment on attachment 97392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97392&action=review r- for the test > LayoutTests/ChangeLog:9 > + * fonts/outline-expected.txt: Added. > + * fonts/outline.html: Added. Why is the test in fonts? I'd suggest fast/css I think the test can also be dumpAsText(true) since you only care about the pixel result. The test should contain no text, and use large outlines to make the fix very obvious. You also need to include a pixel result in your patch.
Created attachment 97571 [details] patch I've changed the test case.
Comment on attachment 97571 [details] patch Can you include binary fixes in your patch (or use webkit-patch upload)?
Created attachment 97730 [details] Patch This is webkit-patch.
Comment on attachment 97730 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97730&action=review > LayoutTests/fast/css/outline-narrowLine.html:1 > +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd"> Is this important to the test? The DOCTYPE used elsewhere, when specified, seems to be: <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd"> But if it doesn't affect the behaviour of the test I would suggest leave it out. > Source/WebCore/rendering/RenderInline.cpp:1527 > + > + if (thisline.x() == thisline.maxX()) > + drawLineForBoxSide(graphicsContext, > + l - ow, > + b, > + r + ow, > + b + ow, > + BSBottom, outlineColor, os, > + ow, > + ow, > + antialias > + ); > + This needs rebasing - the function's variable names have changed.
Created attachment 108241 [details] Patch
Note that for: <span style="outline: solid red 5px"></span> WebKit, unlike firefox, does nothing. This is because empty inlines do not get a renderer in WebKit.
Comment on attachment 108241 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108241&action=review > LayoutTests/fast/css/outline-narrowLine.html:22 > +<html> > +<body> > +<!--Outline around an empty span: WebKit does nothing here, as empty inlines are ignored.--> > +<p> > +<span style="outline: solid red 5px"></span> > +<p> > + > +<!--Outline around a span with a line break:--> > +<p> > +<span style="outline: solid green 5px"><br></span> > +<p> > + > +<!--Outline around a span with a line break and an 'x':--> > +<p> > +<span style="outline: solid blue 5px"><br>x</span> > +<p> > + > +<!--Outline around a span with an 'x' and two line breaks:--> > +<p> > +<span style="outline: solid purple 5px">x<br><br></span> > +</body> > +</html> Can you make this test accentuate the outline? Try 50px-wide outlines.
Committed r95721: <http://trac.webkit.org/changeset/95721>