Bug 36791 - Add assertions for instance proxy validity
Summary: Add assertions for instance proxy validity
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Reported: 2010-03-29 16:12 PDT by Alexey Proskuryakov
Modified: 2010-03-30 10:10 PDT (History)
1 user (show)

See Also:

proposed patch (2.20 KB, patch)
2010-03-29 16:13 PDT, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2010-03-29 16:12:26 PDT
Add some assertions that the instance proxy hasn't been deleted. We sometimes keep a raw pointer to one across complicated function calls, relying on the caller to protect the reference.
Comment 1 Alexey Proskuryakov 2010-03-29 16:13:58 PDT
Created attachment 51979 [details]
proposed patch
Comment 2 WebKit Review Bot 2010-03-29 16:15:46 PDT
Attachment 51979 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.h:75:  More than one command on the same line  [whitespace/newline] [4]
WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.h:81:  More than one command on the same line  [whitespace/newline] [4]
WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.h:82:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 3 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2010-03-30 10:10:03 PDT
Committed revision 56797.