WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
36791
Add assertions for instance proxy validity
https://bugs.webkit.org/show_bug.cgi?id=36791
Summary
Add assertions for instance proxy validity
Alexey Proskuryakov
Reported
2010-03-29 16:12:26 PDT
Add some assertions that the instance proxy hasn't been deleted. We sometimes keep a raw pointer to one across complicated function calls, relying on the caller to protect the reference.
Attachments
proposed patch
(2.20 KB, patch)
2010-03-29 16:13 PDT
,
Alexey Proskuryakov
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2010-03-29 16:13:58 PDT
Created
attachment 51979
[details]
proposed patch
WebKit Review Bot
Comment 2
2010-03-29 16:15:46 PDT
Attachment 51979
[details]
did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.h:75: More than one command on the same line [whitespace/newline] [4] WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.h:81: More than one command on the same line [whitespace/newline] [4] WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.h:82: More than one command on the same line [whitespace/newline] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3
2010-03-30 10:10:03 PDT
Committed revision 56797.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug