Bug 36785 – [Qt, Gtk] Allows build-webkit script to accept custom make command as parameter

• Status: RESOLVED
• Resolution: LATER
• Component: Tools / Tests

[Rodrigo Belem]

The build-webkit script lacks for a parameter to set a custom make command.

A debian/rules snippet as a real world example. 

build-stamp:                                                                                                                                 
       dh_testdir                                                                                                                            
                                                                                                                                             
       WebKitTools/Scripts/build-webkit --qt --make=$(QMAKE)


This enables the dpkg-buildpackage get the make arguments, like -j parameter for distributed builds.

[Rodrigo Belem]

Created attachment 51971 [details]
Patch that adds the --make option.

[Rodrigo Belem]

Adding the keywords qt and gtk.

[Rodrigo Belem]

I made a mistake.

(In reply to comment #0)
> The build-webkit script lacks for a parameter to set a custom make command.
> 
> A debian/rules snippet as a real world example. 
> 
> build-stamp:                                                                    
>        dh_testdir                                                               
> 
>        WebKitTools/Scripts/build-webkit --qt --make=$(QMAKE)
> 

I mean --make=$(MAKE) where I wrote --make=$(QMAKE)

[Kenneth Rohde Christiansen]

How is this different from --makeargs= ? You want to use another make? like gmake?

qmake is not a replacement for make, but a companion.

[Rodrigo Belem]

(In reply to comment #4)
> How is this different from --makeargs= ? You want to use another make? like
> gmake?
>
When building the qtwebkit debian package with the command

dpkg-buildpackage -rfakeroot -j15

and using --makeargs=$(MAKEFLAGS) as following

WebKitTools/Scripts/build-webkit --qt --makeargs=$(MAKEFLAGS)

It does not passes the -j15 correctly to the make command. With the attached patch and the following command in the debian/rules, it works as desired.

WebKitTools/Scripts/build-webkit --qt --make=$(MAKE)


> qmake is not a replacement for make, but a companion.

Sorry. That was a typo.

[Gustavo Noronha (kov)]

(In reply to comment #5)
> When building the qtwebkit debian package with the command
> 
> dpkg-buildpackage -rfakeroot -j15
> 
> and using --makeargs=$(MAKEFLAGS) as following
> 
> WebKitTools/Scripts/build-webkit --qt --makeargs=$(MAKEFLAGS)
> 
> It does not passes the -j15 correctly to the make command. With the attached
> patch and the following command in the debian/rules, it works as desired.

Why not fix the usage of --makeargs, instead, then? I am assuming it should work for your case (in fact, using -j was precisely why it got added in the first place).

[Simon Hausmann]

Comment on attachment 51971 [details]
Patch that adds the --make option.

(In reply to comment #6)
> (In reply to comment #5)
> > When building the qtwebkit debian package with the command
> > 
> > dpkg-buildpackage -rfakeroot -j15
> > 
> > and using --makeargs=$(MAKEFLAGS) as following
> > 
> > WebKitTools/Scripts/build-webkit --qt --makeargs=$(MAKEFLAGS)
> > 
> > It does not passes the -j15 correctly to the make command. With the attached
> > patch and the following command in the debian/rules, it works as desired.
> 
> Why not fix the usage of --makeargs, instead, then? I am assuming it should
> work for your case (in fact, using -j was precisely why it got added in the
> first place).

I agree, fixing the quoting sounds like the better thing to do.

[Kenneth Rohde Christiansen]

Rodrigo do you want to assign this one to you?

[Zan Dobersek]

Is there still interest in getting this done?

[Martin Robinson]

I'm thinking this isn't a big problem any longer, since no one has complained or submitted a fix.