Bug 36781 – [chromium] Enable fast/events/onbeforeunload-focused-iframe.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Charles Reis]

The onbeforeunload-focused-iframe.html layout test was disabled for Chromium until TestShell's LayoutTestController was updated to support it.  That's been fixed, so we can enable this test now.

[Sterling Swigart]

Created attachment 52091 [details]
Proposed fix

[David Levin]

Comment on attachment 52091 [details]
Proposed fix

> diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
> +        * platform/chromium/test_expectations.txt: Enable test now that callShouldCloseOnWebView
> +	is implemented in test_shell.

This is great except for the TAB here.

Please get rid of it and upload and I'll r+,cq+ it for you.

[Sterling Swigart]

Created attachment 52095 [details]
Proposed fix, revision 2

[WebKit Commit Bot]

Comment on attachment 52095 [details]
Proposed fix, revision 2

Rejecting patch 52095 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Last 500 characters of output:
sts/platform/chromium/test_expectations.txt
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe

    The following files contain tab characters:

        trunk/LayoutTests/ChangeLog

    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
 at /usr/local/git/libexec/git-core/git-svn line 558


Full output: http://webkit-commit-queue.appspot.com/results/1618107

[Sterling Swigart]

Created attachment 52179 [details]
Proposed fix, revision 3

[WebKit Commit Bot]

Comment on attachment 52179 [details]
Proposed fix, revision 3

Clearing flags on attachment: 52179

Committed r56848: <http://trac.webkit.org/changeset/56848>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.