Bug 36767 - Add sign in/out link to TestResults appengine
Summary: Add sign in/out link to TestResults appengine
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Victor Wang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-29 11:44 PDT by Victor Wang
Modified: 2010-03-29 17:34 PDT (History)
4 users (show)

See Also:

Attachments
Proposed Patch (3.02 KB, patch)
2010-03-29 11:47 PDT, Victor Wang 		no flags Details | Formatted Diff | Diff
Proposed Patch (3.01 KB, patch)
2010-03-29 11:49 PDT, Victor Wang 		abarth: review-
Details | Formatted Diff | Diff
Proposed Patch (3.04 KB, patch)
2010-03-29 13:44 PDT, Victor Wang 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Wang 2010-03-29 11:44:52 PDT 
Add a link to TestResults appengine so admin can sign in and sign out.

TestResults appengine allows admins to view/do extra stuffs that normal users won't be able to. For example, admin can see a "delete" link next to a file and has the privilege to delete a file.
Comment 1 Victor Wang 2010-03-29 11:47:15 PDT 
Created attachment 51941 [details]
Proposed Patch
Comment 2 Victor Wang 2010-03-29 11:49:50 PDT 
Created attachment 51942 [details]
Proposed Patch
Comment 3 Ojan Vafai 2010-03-29 12:09:45 PDT 
Comment on attachment 51942 [details]
Proposed Patch

> +        user = users.get_current_user()
> +        if user:
> +            user_email = user.email()
> +            sign = "Sign out"
> +            sign_url = users.create_logout_url(self.request.uri)

How about calling these login_text and login_url? "sign" could mean other things.

> +.sign {

s/sign/login ?

Otherwise, looks good.
Comment 4 Adam Barth 2010-03-29 13:06:46 PDT 
Comment on attachment 51942 [details]
Proposed Patch

Please address Ojan's feedback.
Comment 5 Victor Wang 2010-03-29 13:44:10 PDT 
Created attachment 51963 [details]
Proposed Patch

names updated. please take a look.
Comment 6 Adam Barth 2010-03-29 14:01:31 PDT 
Comment on attachment 51963 [details]
Proposed Patch

LGTM
Comment 7 WebKit Commit Bot 2010-03-29 17:34:50 PDT 
Comment on attachment 51963 [details]
Proposed Patch

Clearing flags on attachment: 51963

Committed r56753: <http://trac.webkit.org/changeset/56753>
Comment 8 WebKit Commit Bot 2010-03-29 17:34:55 PDT 
All reviewed patches have been landed.  Closing bug.