RESOLVED FIXED 36767
Add sign in/out link to TestResults appengine 
https://bugs.webkit.org/show_bug.cgi?id=36767
Summary Add sign in/out link to TestResults appengine
Victor Wang
Reported 2010-03-29 11:44:52 PDT
Add a link to TestResults appengine so admin can sign in and sign out. TestResults appengine allows admins to view/do extra stuffs that normal users won't be able to. For example, admin can see a "delete" link next to a file and has the privilege to delete a file.
Attachments
Proposed Patch (3.02 KB, patch)
2010-03-29 11:47 PDT, Victor Wang 		no flags
DetailsFormatted DiffDiff
Proposed Patch (3.01 KB, patch)
2010-03-29 11:49 PDT, Victor Wang 		abarth: review-
DetailsFormatted DiffDiff
Proposed Patch (3.04 KB, patch)
2010-03-29 13:44 PDT, Victor Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Victor Wang
Comment 1 2010-03-29 11:47:15 PDT
Created attachment 51941 [details] Proposed Patch
Victor Wang
Comment 2 2010-03-29 11:49:50 PDT
Created attachment 51942 [details] Proposed Patch
Ojan Vafai
Comment 3 2010-03-29 12:09:45 PDT
Comment on attachment 51942 [details] Proposed Patch > + user = users.get_current_user() > + if user: > + user_email = user.email() > + sign = "Sign out" > + sign_url = users.create_logout_url(self.request.uri) How about calling these login_text and login_url? "sign" could mean other things. > +.sign { s/sign/login ? Otherwise, looks good.
Adam Barth
Comment 4 2010-03-29 13:06:46 PDT
Comment on attachment 51942 [details] Proposed Patch Please address Ojan's feedback.
Victor Wang
Comment 5 2010-03-29 13:44:10 PDT
Created attachment 51963 [details] Proposed Patch names updated. please take a look.
Adam Barth
Comment 6 2010-03-29 14:01:31 PDT
Comment on attachment 51963 [details] Proposed Patch LGTM
WebKit Commit Bot
Comment 7 2010-03-29 17:34:50 PDT
Comment on attachment 51963 [details] Proposed Patch Clearing flags on attachment: 51963 Committed r56753: <http://trac.webkit.org/changeset/56753>
WebKit Commit Bot
Comment 8 2010-03-29 17:34:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.