Bug 36759 – check-webkit-style: Eliminate explicit slash characters from _rel_path()

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Chris Jerdonek]

Eliminate explicit slash characters from _rel_path(), as discussed here:

https://bugs.webkit.org/show_bug.cgi?id=35498#c27

This will make the implementation more platform-independent.

[Chris Jerdonek]

Created attachment 51922 [details]
Proposed patch

[Shinichiro Hamaji]

Comment on attachment 51922 [details]
Proposed patch

> -    if rel_path and rel_path[0] not in slash_chars:
> -        # Then we are in the case typified by the following example:
> +    if not rel_path:
> +        # Then the paths are the same.
> +        pass

Ah, this patch let me notice we cannot run check-webkit-style with the root checkout directory

% ./WebKitTools/Scripts/check-webkit-style `pwd`  # in WebKit checkout directory
File not a recognized type to check. Skipping: ""
Total errors found: 0 in 1 files

and

% ./WebKitTools/Scripts/check-webkit-style .  # in WebKit checkout directory
File not a recognized type to check. Skipping: ""
Total errors found: 0 in 1 files

But this would be another issue. Let's go ahead as is.

[Chris Jerdonek]

(In reply to comment #2)
> (From update of attachment 51922 [details])
> > -    if rel_path and rel_path[0] not in slash_chars:
> > -        # Then we are in the case typified by the following example:
> > +    if not rel_path:
> > +        # Then the paths are the same.
> > +        pass
> 
> Ah, this patch let me notice we cannot run check-webkit-style with the root
> checkout directory

Yes, I was wondering about that.  It looks like it might suffice to return os.curdir in that case.  But yes, we can do that later.

[WebKit Commit Bot]

Comment on attachment 51922 [details]
Proposed patch

Clearing flags on attachment: 51922

Committed r56747: <http://trac.webkit.org/changeset/56747>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.