Bug 36754 - [GTK] webkit_get_default_session() should make sure webkit_init() is called
Summary: [GTK] webkit_get_default_session() should make sure webkit_init() is called
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2010-03-29 06:46 PDT by Gustavo Noronha (kov)
Modified: 2010-04-01 09:07 PDT (History)
1 user (show)

See Also:

proposed fix (6.44 KB, patch)
2010-03-29 07:43 PDT, Gustavo Noronha (kov)
zecke: review+
gustavo: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2010-03-29 06:46:47 PDT
While writing an application that does not create a WebView early in its life, but that does all of the setup right away, I noticed my removal of the soup auth dialog feature was not having any effect. That is because webkit_init was not called much later, when the first WebView is created, and then adds the feature I tried to remove. I have solved this by creating, and destroying a WebView while setting up the session (ugh).
Comment 1 Gustavo Noronha (kov) 2010-03-29 07:43:33 PDT
Created attachment 51907 [details]
proposed fix
Comment 2 Holger Freyther 2010-03-31 02:14:25 PDT
Comment on attachment 51907 [details]
proposed fix

> +// Make sure the session is initialized properly when webkit_get_default_session() is called.
> +static void test_globals_default_session()
> +{

I think you want to call g_test_bug("36754"); here. Besides that the webkit_init call will call get_default_session and set_cache_model but that
is fine as we have an early exit in there.
Comment 3 Gustavo Noronha (kov) 2010-04-01 09:07:43 PDT
Landed as r56916.