gcc for Symbian doesn't support gcc extensions like atomicity.h and fails on including them.
Created attachment 51881 [details] Proposed fix JavaScriptCore/wtf/Threading.h: gcc for Symbian doesn't support gcc extensions like atomicity.h - disable
Attachment 51881 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 51884 [details] Proposed fix
Attachment 51884 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.
running it locally shows no problems, not sure how to fix then :( WebKitTools/Scripts/check-webkit-style Total errors found: 0 in 2 files
Comment on attachment 51884 [details] Proposed fix Looks good to me. I'll land it manually.
(In reply to comment #6) > (From update of attachment 51884 [details]) > Looks good to me. I'll land it manually. (Manual because the patch doesn't apply with the standard tools, missing context it seems)
Committed r56712: <http://trac.webkit.org/changeset/56712>
Revision r56712 cherry-picked into qtwebkit-2.0 with commit 2b6255889c50a45035c045fd4575590f57887848
Build 4429 (r56712) was the first to show failures: set([u'fast/js/kde/string-1-n.html', u'fast/js/kde/string-2-n.html']) Suspect revisions: r56712: http://trac.webkit.org/changeset/56712 Bug: 36742 (https://bugs.webkit.org/show_bug.cgi?id=36742) Author: "Thomas Zander" <t.zander@nokia.com> Reviewer: "Simon Hausmann" <hausmann@webkit.org> Committer: "Simon Hausmann" <hausmann@webkit.org> It appears this change caused a failure on teh Gtk 32-bit debug bot.