Bug 3674 – GW: Add CGPoint and other small fixes to KWQPoint*

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Add CGPoint and other small fixes to KWQPoint*

including adding:
QPoint::setX(int)
QPoint::setY(int)
QPoint::isNull()

QPointArray::QPointArray(QRect)
QPointArray::boundingRect()
QPointArray::copy()
QPointArray::point(int, int *, int *)

[Eric Seidel (no email)]

Created attachment 2578 [details]
Adds CGPoint support, as well as various other small fixes

Please pardon the few additional white-space changes.  I ran a "re-indent"
command over the entire file to replace tabs w/ spaces... it added a few spaces
where there were not before.

[Darin Adler]

Comment on attachment 2578 [details]
Adds CGPoint support, as well as various other small fixes

The operator * implementation does not match our coding style. The "{" should
be on a second line.

The implementation of isNull() has some extra punctuation and spaces in it.
Should just be "return xCoord == 0 && yCoord == 0;".

There are extra spaces in the setPoints call inside the QPointArray constructor
that takes a QRect. I know that matches the existing constructor, but it does
not match our coding cuidelines.

In QPointArray::copy, it would be better to use a static_cast rather than a
C-style cast.

The boundingRect and point functions have the "{" o the same line as the
function declaration, but it should be on the next line.

The call to QMemArray<QPoint>::at(index) inside QPointArray::point, should just
be a call to at(index).

[Eric Seidel (no email)]

Created attachment 2604 [details]
Formatting oversights now fixed.

[Darin Adler]

Comment on attachment 2604 [details]
Formatting oversights now fixed.

Forward declaration of class QRect should be at the top of the file.

No space after "-=" in operator -= declaration.

When importing things in the KWQ directory, don't use forwarding headers. Hence
it should be:

    #import "KWQRect.h"

Otherwise, looks fine.

[Eric Seidel (no email)]

Created attachment 2713 [details]
addressed Darin's concerns

[Maks Orlovich]

Is it just me, or does this never use minX > 0, minY > 0 for the top-left 
corner of the rectangle?  
 

[Eric Seidel (no email)]

Created attachment 2824 [details]
Addressed SadEagle's boundingRect() concern.

[Eric Seidel (no email)]

Comment on attachment 2713 [details]
addressed Darin's concerns

Replaced patch to fix SadEagle's boundingRect() concerns.

[Maciej Stachowiak]

r=me