WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
36733
Use a common header for Windows virtual key codes on all platforms
https://bugs.webkit.org/show_bug.cgi?id=36733
Summary
Use a common header for Windows virtual key codes on all platforms
Alexey Proskuryakov
Reported
2010-03-28 13:49:30 PDT
Currently, we have multiple headers define VK_* key codes. There is no reason for that, they are all the same and match Windows.
Attachments
proposed patch
(143.62 KB, patch)
2010-03-28 14:03 PDT
,
Alexey Proskuryakov
no flags
Details
Formatted Diff
Diff
proposed patch
(143.70 KB, patch)
2010-03-28 14:48 PDT
,
Alexey Proskuryakov
sam
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2010-03-28 14:03:38 PDT
Created
attachment 51867
[details]
proposed patch
Alexey Proskuryakov
Comment 2
2010-03-28 14:48:54 PDT
Created
attachment 51869
[details]
proposed patch Updated to apply to ToT.
Sam Weinig
Comment 3
2010-03-28 18:20:57 PDT
Comment on
attachment 51869
[details]
proposed patch In the words of Mark Rowe, "awesomesauce".
Alexey Proskuryakov
Comment 4
2010-03-28 20:41:53 PDT
Committed revision 56704. i saw that EWS complained about Qt build, but it didn't tell what was wrong.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug