Bug 36733 - Use a common header for Windows virtual key codes on all platforms
Summary: Use a common header for Windows virtual key codes on all platforms
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Reported: 2010-03-28 13:49 PDT by Alexey Proskuryakov
Modified: 2010-03-29 04:08 PDT (History)
0 users

See Also:

proposed patch (143.62 KB, patch)
2010-03-28 14:03 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
proposed patch (143.70 KB, patch)
2010-03-28 14:48 PDT, Alexey Proskuryakov
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2010-03-28 13:49:30 PDT
Currently, we have multiple headers define VK_* key codes. There is no reason for that, they are all the same and match Windows.
Comment 1 Alexey Proskuryakov 2010-03-28 14:03:38 PDT
Created attachment 51867 [details]
proposed patch
Comment 2 Alexey Proskuryakov 2010-03-28 14:48:54 PDT
Created attachment 51869 [details]
proposed patch

Updated to apply to ToT.
Comment 3 Sam Weinig 2010-03-28 18:20:57 PDT
Comment on attachment 51869 [details]
proposed patch

In the words of Mark Rowe, "awesomesauce".
Comment 4 Alexey Proskuryakov 2010-03-28 20:41:53 PDT
Committed revision 56704.

i saw that EWS complained about Qt build, but it didn't tell what was wrong.