RESOLVED FIXED 3673
GW: Add QBuffer::setBuffer(QByteArray) support to KWQBuffer 
https://bugs.webkit.org/show_bug.cgi?id=3673
Summary GW: Add QBuffer::setBuffer(QByteArray) support to KWQBuffer
Eric Seidel (no email)
Reported 2005-06-23 02:56:26 PDT
Adds QBuffer::setBuffer(QByteArray) support to KWQBuffer also adds QBuffer(QByteArray) constructor. The only thing I'm not sure about in this patch is the "open" state after setBuffer. However, I'm also pretty sure that it doesn't matter... at least for this minimalist implementation of QBuffer. Again code has been tested locally and does not affect the rest of WebKit.
Attachments
Adds setBuffer() support and a QByteArray based constructor (1.06 KB, patch)
2005-06-23 02:58 PDT, Eric Seidel (no email) 		darin: review-
DetailsFormatted DiffDiff
Formatting oversights now fixed. (1.07 KB, patch)
2005-06-23 09:23 PDT, Eric Seidel (no email) 		darin: review-
DetailsFormatted DiffDiff
Fixed QByteArray & (1.07 KB, patch)
2005-06-23 12:55 PDT, Eric Seidel (no email) 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2005-06-23 02:58:21 PDT
Created attachment 2577 [details] Adds setBuffer() support and a QByteArray based constructor
Darin Adler
Comment 2 2005-06-23 07:14:47 PDT
Comment on attachment 2577 [details] Adds setBuffer() support and a QByteArray based constructor Formatting of QBuffer::setBuffer does not match our coding guidelines. The "{" should be on the line after the declaration, not on the same line. Also, the "if (isOpen()) return false;" should be broken into two lines rather than together on one. Other than the coding guidelines issue, this looks great.
Eric Seidel (no email)
Comment 3 2005-06-23 09:23:35 PDT
Created attachment 2589 [details] Formatting oversights now fixed.
Darin Adler
Comment 4 2005-06-23 10:01:40 PDT
Comment on attachment 2589 [details] Formatting oversights now fixed. The parameter to the QBuffer constructor should be QByteArray, not QByteArray &, to match Qt. If it's going to be a reference, then I suggest that we make it const QByteArray & and do the same with the parameter to setBuffer. Otherwise, looks good.
Eric Seidel (no email)
Comment 5 2005-06-23 12:55:22 PDT
Created attachment 2606 [details] Fixed QByteArray &
Darin Adler
Comment 6 2005-06-23 22:58:06 PDT
Comment on attachment 2606 [details] Fixed QByteArray & r=me
Note You need to log in before you can comment on or make changes to this bug.