Bug 36720 - Web Inspector: Toggling style properties on/off does not always work.
: Web Inspector: Toggling style properties on/off does not always work.
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Pavel Feldman
Depends on:
  Show dependency treegraph
Reported: 2010-03-28 04:57 PDT by Pavel Feldman
Modified: 2010-03-28 10:49 PDT (History)
5 users (show)

See Also:

[PATCH] Proposed fix. (8.16 KB, patch)
2010-03-28 05:00 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-03-28 04:57:09 PDT
Re-using dangling CSSStyleDeclaration as a storage for disables style properties turned out to be a bad idea. Styles with urls (such as content: url(...) ) are not parsed well unless there is an associated stylesheet. This patch fixes it.
Comment 1 Pavel Feldman 2010-03-28 05:00:00 PDT
Created attachment 51858 [details]
[PATCH] Proposed fix.
Comment 2 Pavel Feldman 2010-03-28 10:41:38 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorDOMAgent.cpp
	M	WebCore/inspector/InspectorDOMAgent.h
	M	WebCore/inspector/front-end/DOMAgent.js
	M	WebCore/inspector/front-end/StylesSidebarPane.js
Committed r56697
Comment 3 Pavel Feldman 2010-03-28 10:49:31 PDT
Comment on attachment 51858 [details]
[PATCH] Proposed fix.

Landed manually.