Bug 36720 - Web Inspector: Toggling style properties on/off does not always work.
: Web Inspector: Toggling style properties on/off does not always work.
Status: RESOLVED FIXED
: WebKit
Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-03-28 04:57 PST by
Modified: 2010-03-28 10:49 PST (History)


Attachments
[PATCH] Proposed fix. (8.16 KB, patch)
2010-03-28 05:00 PST, Pavel Feldman
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-03-28 04:57:09 PST
Re-using dangling CSSStyleDeclaration as a storage for disables style properties turned out to be a bad idea. Styles with urls (such as content: url(...) ) are not parsed well unless there is an associated stylesheet. This patch fixes it.
------- Comment #1 From 2010-03-28 05:00:00 PST -------
Created an attachment (id=51858) [details]
[PATCH] Proposed fix.
------- Comment #2 From 2010-03-28 10:41:38 PST -------
Committing to http://svn.webkit.org/repository/webkit/trunk ...
    M    WebCore/ChangeLog
    M    WebCore/inspector/InspectorController.cpp
    M    WebCore/inspector/InspectorDOMAgent.cpp
    M    WebCore/inspector/InspectorDOMAgent.h
    M    WebCore/inspector/front-end/DOMAgent.js
    M    WebCore/inspector/front-end/StylesSidebarPane.js
Committed r56697
------- Comment #3 From 2010-03-28 10:49:31 PST -------
(From update of attachment 51858 [details])
Landed manually.