Bug 36719 - Web Inspector: Consolidate Tree Hierarchy Attribute HTML Generation
Summary: Web Inspector: Consolidate Tree Hierarchy Attribute HTML Generation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-28 03:12 PDT by Joseph Pecoraro
Modified: 2010-03-28 03:36 PDT (History)
7 users (show)

See Also:

Attachments
[PATCH] Consolidate to _attributeHTML (6.28 KB, patch)
2010-03-28 03:14 PDT, Joseph Pecoraro 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2010-03-28 03:12:18 PDT 
Attribute HTML is generated in 3 different places:
- updateTitle the core location (name+value, linkifies, and tooltips)
- _addNewAttribute (blank name+value, no equals or quotes)
- regenerateStyledAttribute (when tabbing, name+value, no linkify)

These can become out of sync. They should be consolidated.
Comment 1 Joseph Pecoraro 2010-03-28 03:14:35 PDT 
Created attachment 51854 [details]
[PATCH] Consolidate to _attributeHTML
Comment 2 Joseph Pecoraro 2010-03-28 03:36:35 PDT 
Committed r56688
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ElementsTreeOutline.js
r56688 = 0b5ebc1a1afceb39553d882c9e6fb64e4bb8cb72 (trunk)
http://trac.webkit.org/changeset/56688