Bug 36712 - webkitpy: delete the unittests.py files
Summary: webkitpy: delete the unittests.py files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chris Jerdonek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-27 16:07 PDT by Chris Jerdonek
Modified: 2010-03-27 19:50 PDT (History)
6 users (show)

See Also:


Attachments
Proposed patch (18.03 KB, patch)
2010-03-27 16:20 PDT, Chris Jerdonek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jerdonek 2010-03-27 16:07:24 PDT
We can delete these now that test-webkitpy auto-detects the *_unittest modules:

https://bugs.webkit.org/show_bug.cgi?id=36591
Comment 1 Chris Jerdonek 2010-03-27 16:18:32 PDT
By the way, I noticed that this file needs to be renamed (no "s" at the end):

./WebKitTools/Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py
Comment 2 Chris Jerdonek 2010-03-27 16:20:16 PDT
Created attachment 51847 [details]
Proposed patch
Comment 3 Adam Barth 2010-03-27 16:24:12 PDT
Comment on attachment 51847 [details]
Proposed patch

Yay.  Useless code begone.

You have my rubberstamp to rename that file.
Comment 4 Chris Jerdonek 2010-03-27 16:31:08 PDT
(In reply to comment #3)
> (From update of attachment 51847 [details])
> Yay.  Useless code begone.
> 
> You have my rubberstamp to rename that file.

Fixed: http://trac.webkit.org/changeset/56672
Comment 5 WebKit Commit Bot 2010-03-27 19:50:45 PDT
Comment on attachment 51847 [details]
Proposed patch

Clearing flags on attachment: 51847

Committed r56677: <http://trac.webkit.org/changeset/56677>
Comment 6 WebKit Commit Bot 2010-03-27 19:50:50 PDT
All reviewed patches have been landed.  Closing bug.