Bug 36694 – Make XSSAuditor go fast with large POST data

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Adam Barth]

This bug is a followup to https://bugs.webkit.org/show_bug.cgi?id=35373.  In that bug, we got within a factor of four of the auditor-disabled speed.  In this bug, we're going do a lot better in this benchmark.

I've hosted the benchmark here for convenience:
http://webblaze.org/abarth/tests/slow-filter/webkit-test-5.php

[Adam Barth]

I hate git.  I just deleted all my work.  :(

[Adam Barth]

TextMate, however, is awesome and recovered all my code.

[Adam Barth]

Created attachment 51817 [details]
Patch

[WebKit Review Bot]

Attachment 51817 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/page/XSSAuditor.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Barth]

Comment on attachment 51817 [details]
Patch

Will fix some nits.

[Adam Barth]

Created attachment 51818 [details]
Patch

[Adam Barth]

Here are some run times for that benchmark:

XSSAuditor enabled:
1562
1531
1652

XSSAuditor disabled:
1525
1538
1571

I ran it a bunch more times, and anecdotally the benchmark seemed to have higher variance than these number.  However, I didn't keep records, so it's hard to draw conclusions.

In any case, the overhead is much smaller (even in this pathological case) using the suffix tree.

[WebKit Review Bot]

Attachment 51818 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/page/XSSAuditor.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Daniel Bates]

Comment on attachment 51818 [details]
Patch

I would suggest adding SuffixTree to the Xcode project code for consistency with the changes to the other projects files even though the Mac EWS does not report any issues.

Looks good to me.

r=me

[Adam Barth]

Created attachment 52398 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 52398 [details]
Patch for landing

Clearing flags on attachment: 52398

Committed r56991: <http://trac.webkit.org/changeset/56991>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.