This bug is a followup to https://bugs.webkit.org/show_bug.cgi?id=35373. In that bug, we got within a factor of four of the auditor-disabled speed. In this bug, we're going do a lot better in this benchmark. I've hosted the benchmark here for convenience: http://webblaze.org/abarth/tests/slow-filter/webkit-test-5.php
I hate git. I just deleted all my work. :(
TextMate, however, is awesome and recovered all my code.
Created attachment 51817 [details] Patch
Attachment 51817 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/page/XSSAuditor.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 51817 [details] Patch Will fix some nits.
Created attachment 51818 [details] Patch
Here are some run times for that benchmark: XSSAuditor enabled: 1562 1531 1652 XSSAuditor disabled: 1525 1538 1571 I ran it a bunch more times, and anecdotally the benchmark seemed to have higher variance than these number. However, I didn't keep records, so it's hard to draw conclusions. In any case, the overhead is much smaller (even in this pathological case) using the suffix tree.
Attachment 51818 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/page/XSSAuditor.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 51818 [details] Patch I would suggest adding SuffixTree to the Xcode project code for consistency with the changes to the other projects files even though the Mac EWS does not report any issues. Looks good to me. r=me
Created attachment 52398 [details] Patch for landing
Comment on attachment 52398 [details] Patch for landing Clearing flags on attachment: 52398 Committed r56991: <http://trac.webkit.org/changeset/56991>
All reviewed patches have been landed. Closing bug.