new-run-webkit-tests seems to be unstable w/ more than 4 threads running in parallel (see bug 36622). Change the default until that bug is fixed.
Created attachment 51803 [details] Patch
How does this issue relate to this code? http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/system/executive.py#L121
(In reply to comment #2) > How does this issue relate to this code? > > http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/system/executive.py#L121 new-run-webkit-tests doesn't use that code, and I have no idea where that code is used. I'm not sure if that answers your questin?
(In reply to comment #3) > (In reply to comment #2) > > How does this issue relate to this code? > > > > http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/system/executive.py#L121 > > new-run-webkit-tests doesn't use that code, and I have no idea where that code > is used. I'm not sure if that answers your questin? Superficially, it looks like we have two ways of getting the CPU (core?) count in our code base. If they are doing the same thing, we might want to combine those code paths.
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > How does this issue relate to this code? > > > > > > http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/system/executive.py#L121 > > > > new-run-webkit-tests doesn't use that code, and I have no idea where that code > > is used. I'm not sure if that answers your questin? > > Superficially, it looks like we have two ways of getting the CPU (core?) count > in our code base. If they are doing the same thing, we might want to combine > those code paths. Yes, you are correct. There's a lot of duplication between the port/* interface and code written outside of the layout_tests directory, and we haven't really tried to reduce that yet. Nobody has yet proposed what the right structure is, and I've been mostly focused on simply getting the new-run-webkit-tests to be bug-free and feature-equivalent to the Perl code.
Comment on attachment 51803 [details] Patch ok.
Comment on attachment 51803 [details] Patch Clearing flags on attachment: 51803 Committed r56746: <http://trac.webkit.org/changeset/56746>
All reviewed patches have been landed. Closing bug.