Bug 36672 - Assertion failure: !repaintContainer || repaintContainer == this
Summary: Assertion failure: !repaintContainer || repaintContainer == this
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Simon Fraser (smfr)
URL: http://www.floreysoft.net/#main2produ...
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-26 12:41 PDT by Alexey Proskuryakov
Modified: 2010-04-01 11:19 PDT (History)
2 users (show)

See Also:


Attachments
Testcase (785 bytes, text/html)
2010-03-30 15:14 PDT, Simon Fraser (smfr)
no flags Details
Patch (4.17 KB, patch)
2010-04-01 11:11 PDT, Simon Fraser (smfr)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2010-03-26 12:41:34 PDT
Opening http://www.floreysoft.net/#main2product0sharedcontacts1

ASSERTION FAILED: !repaintContainer || repaintContainer == this
(/Volumes/Data/Safari/OpenSource/WebCore/rendering/RenderView.cpp:266 virtual void WebCore::RenderView::computeRectForRepaint(WebCore::RenderBoxModelObject*, WebCore::IntRect&, bool))
Comment 1 Alexey Proskuryakov 2010-03-26 12:42:13 PDT
With r56633.
Comment 2 Simon Fraser (smfr) 2010-03-26 17:16:08 PDT
I can't reproduce this. I don't see any compositing stuff on this page at all.
Comment 3 Alexey Proskuryakov 2010-03-26 17:35:17 PDT
I can still reproduce with ToT, r56648.
Comment 4 Alexey Proskuryakov 2010-03-27 13:33:13 PDT
FWIW, this didn't happen for me under Fast Malloc.
Comment 5 Simon Fraser (smfr) 2010-03-29 15:25:53 PDT
Alexey: are you reproducing in a normal debug build?
Comment 6 Alexey Proskuryakov 2010-03-29 15:36:48 PDT
Oops, comment 4 was meant to say "cannot reproduce under Guard Malloc". I can reproduce with normal debug build.
Comment 7 Simon Fraser (smfr) 2010-03-30 14:10:49 PDT
I can reproduce now.
Comment 8 Simon Fraser (smfr) 2010-03-30 15:14:37 PDT
Created attachment 52087 [details]
Testcase
Comment 9 Simon Fraser (smfr) 2010-03-31 16:42:56 PDT
The problem here is that RenderText::clippedOverflowRectForRepaint() is calling containingBlock(), which skips the repaint container.
Comment 10 Simon Fraser (smfr) 2010-04-01 11:11:40 PDT
Created attachment 52313 [details]
Patch
Comment 11 mitz 2010-04-01 11:15:12 PDT
Comment on attachment 52313 [details]
Patch

> +        Test for repainting where the repaintContainer is a descendent of the containing block.

Google says: Did you mean: descendant

> +        So in this case, check to see whether repaintContainer is actually a descendent of the

Ditto.
Comment 12 Simon Fraser (smfr) 2010-04-01 11:19:40 PDT
http://trac.webkit.org/changeset/56924