WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
36669
Use WebKitClient to instantiate WebGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=36669
Summary
Use WebKitClient to instantiate WebGraphicsContext3D
Kenneth Russell
Reported
2010-03-26 11:12:57 PDT
In order to create a browser-specific WebGraphicsContext3D instance, WebKitClient::createGraphicsContext3D() needs to be used to instantiate it rather than WebGraphicsContext3D::createDefault().
Attachments
Patch
(1.48 KB, patch)
2010-03-26 11:16 PDT
,
Kenneth Russell
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kenneth Russell
Comment 1
2010-03-26 11:16:50 PDT
Created
attachment 51764
[details]
Patch Note to reviewers: please don't cq+ this; Chromium changes need to land first. Want to get this ready to land, though.
Darin Adler
Comment 2
2010-03-26 11:21:54 PDT
(In reply to
comment #1
)
> Note to reviewers: please don't cq+ this; Chromium changes need to land first. > Want to get this ready to land, though.
Setting cq- on a patch is another way to indicate that.
Darin Fisher (:fishd, Google)
Comment 3
2010-03-26 11:39:07 PDT
Comment on
attachment 51764
[details]
Patch
> Index: WebKit/chromium/src/GraphicsContext3D.cpp
...
> + WebKit::WebGraphicsContext3D* webContext = WebKit::webKitClient()->createGraphicsContext3D();
R=me, but please note (and sorry for not noting this before) that we typically add a 'using namespace WebKit' at the top of .cpp files like this so that we don't need the WebKit:: prefix everywhere.
Kenneth Russell
Comment 4
2010-03-27 21:17:16 PDT
Comment on
attachment 51764
[details]
Patch Clearing flags on attachment: 51764 Committed
r56678
: <
http://trac.webkit.org/changeset/56678
>
Kenneth Russell
Comment 5
2010-03-27 21:17:20 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug