Bug 36669 – Use WebKitClient to instantiate WebGraphicsContext3D

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Kenneth Russell]

In order to create a browser-specific WebGraphicsContext3D instance, WebKitClient::createGraphicsContext3D() needs to be used to instantiate it rather than WebGraphicsContext3D::createDefault().

[Kenneth Russell]

Created attachment 51764 [details]
Patch

Note to reviewers: please don't cq+ this; Chromium changes need to land first. Want to get this ready to land, though.

[Darin Adler]

(In reply to comment #1)
> Note to reviewers: please don't cq+ this; Chromium changes need to land first.
> Want to get this ready to land, though.

Setting cq- on a patch is another way to indicate that.

[Darin Fisher (:fishd, Google)]

Comment on attachment 51764 [details]
Patch

> Index: WebKit/chromium/src/GraphicsContext3D.cpp
...
> +    WebKit::WebGraphicsContext3D* webContext = WebKit::webKitClient()->createGraphicsContext3D();

R=me, but please note (and sorry for not noting this before) that we
typically add a 'using namespace WebKit' at the top of .cpp files like
this so that we don't need the WebKit:: prefix everywhere.

[Kenneth Russell]

Comment on attachment 51764 [details]
Patch

Clearing flags on attachment: 51764

Committed r56678: <http://trac.webkit.org/changeset/56678>

[Kenneth Russell]

All reviewed patches have been landed.  Closing bug.