Bug 36669 - Use WebKitClient to instantiate WebGraphicsContext3D
Summary: Use WebKitClient to instantiate WebGraphicsContext3D
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-26 11:12 PDT by Kenneth Russell
Modified: 2010-03-27 21:17 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2010-03-26 11:16 PDT, Kenneth Russell 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-03-26 11:12:57 PDT 
In order to create a browser-specific WebGraphicsContext3D instance, WebKitClient::createGraphicsContext3D() needs to be used to instantiate it rather than WebGraphicsContext3D::createDefault().
Comment 1 Kenneth Russell 2010-03-26 11:16:50 PDT 
Created attachment 51764 [details]
Patch

Note to reviewers: please don't cq+ this; Chromium changes need to land first. Want to get this ready to land, though.
Comment 2 Darin Adler 2010-03-26 11:21:54 PDT 
(In reply to comment #1)
> Note to reviewers: please don't cq+ this; Chromium changes need to land first.
> Want to get this ready to land, though.

Setting cq- on a patch is another way to indicate that.
Comment 3 Darin Fisher (:fishd, Google) 2010-03-26 11:39:07 PDT 
Comment on attachment 51764 [details]
Patch

> Index: WebKit/chromium/src/GraphicsContext3D.cpp
...
> +    WebKit::WebGraphicsContext3D* webContext = WebKit::webKitClient()->createGraphicsContext3D();

R=me, but please note (and sorry for not noting this before) that we
typically add a 'using namespace WebKit' at the top of .cpp files like
this so that we don't need the WebKit:: prefix everywhere.
Comment 4 Kenneth Russell 2010-03-27 21:17:16 PDT 
Comment on attachment 51764 [details]
Patch

Clearing flags on attachment: 51764

Committed r56678: <http://trac.webkit.org/changeset/56678>
Comment 5 Kenneth Russell 2010-03-27 21:17:20 PDT 
All reviewed patches have been landed.  Closing bug.