Bug 36662 – Add support for iframe flattening

• Status: CLOSED
• Resolution: FIXED
• Component: New Bugs

[Kenneth Rohde Christiansen]

Created attachment 51741 [details]
Patch

Add support for expanding iframes to their contents, just as done on the iPhone.

[Kenneth Rohde Christiansen]

After landed we will probably need to rebase the test results with our Qt buildbot.

[Simon Hausmann]

(In reply to comment #1)
> After landed we will probably need to rebase the test results with our Qt
> buildbot.

When you do that, please let me know which revisions for the test result fixes need to be cherry-picked.

[Eric Seidel (no email)]

Attachment 51741 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/1323023

[Antti Koivisto]

Comment on attachment 51741 [details]
Patch

Looks good, r=me 

I don't have any really substantial comments just one naming objection:

> -    if (flattenFrameSet())
> +    if (shouldResizeFramesToContent())
>          positionFramesWithFlattening();

Why this renaming? The naming was discussed quite a bit, lets stick with the "flatten" terminology now.

You now have shouldResizeFramesToContent() method in both RenderFrameSet and RenderPartObject (with rather different semantics), even though those are not really related classes. Why do they need to have same names? Why not stick with RenderFrameSet::flattenFrameSet() and add RenderPartObject::flattenFrame() or similar?

[Kenneth Rohde Christiansen]

Created attachment 51760 [details]
Patch 2 (should build on mac, win etc)

[Eric Seidel (no email)]

Attachment 51760 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/1444004

[Csaba Osztrogonác]

Created attachment 51767 [details]
follow up patch for "patch 2"

[Kenneth Rohde Christiansen]

Comment on attachment 51767 [details]
follow up patch for "patch 2"

We will put it on the cq when the other land.

[Csaba Osztrogonác]

Created attachment 51773 [details]
Patch 2b (should build on mac, win etc)

Uploaded for Kenneth with Mac fix:
-__ZN7WebCore8Settings28setFrameFlatteningEnabledEb
+__ZN7WebCore8Settings25setFrameFlatteningEnabledEb

[Antti Koivisto]

Comment on attachment 51767 [details]
follow up patch for "patch 2"

Please upload one patch that works without having to patch it again with a second one.

[Kenneth Rohde Christiansen]

Created attachment 51904 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 51904 [details]
Patch

Landed in 56718

[Csaba Osztrogonác]

(In reply to comment #11)
> Created an attachment (id=51904) [details]
> Patch

Mac expected files updated:
http://trac.webkit.org/changeset/56720
http://trac.webkit.org/changeset/56722

[Eric Seidel (no email)]

Comment on attachment 51741 [details]
Patch

Cleared Antti Koivisto's review+ from obsolete attachment 51741 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Eric Seidel (no email)]

Comment on attachment 51904 [details]
Patch

Cleared Antti Koivisto's review+ from obsolete attachment 51904 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Simon Hausmann]

cherry-pick-for-backport: <r56718>

[Simon Hausmann]

cherry-pick-for-backport: <r56720>

[Simon Hausmann]

cherry-pick-for-backport: <r56722>

[Simon Hausmann]

Revision r56718 cherry-picked into qtwebkit-2.0 with commit b74f1de36d3e514dc6e1d6293cd7834286071380

[Simon Hausmann]

Revision r56720 cherry-picked into qtwebkit-2.0 with commit eb76591b64df4c459a9b291a85163f09748a4c98

[Simon Hausmann]

Revision r56722 cherry-picked into qtwebkit-2.0 with commit bb360f64ed44718420472bdcc41a8060e0bfc1b8