Bug 36653 - [GStreamer] define static variables with DEFINE_STATIC_LOCAL macro
Summary: [GStreamer] define static variables with DEFINE_STATIC_LOCAL macro
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-03-26 04:06 PDT by Philippe Normand
Modified: 2010-03-29 00:41 PDT (History)
1 user (show)

See Also:

proposed patch (1.70 KB, patch)
2010-03-26 04:17 PDT, Philippe Normand
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-03-26 04:06:01 PDT
In mimeTypeCache() the 2 static vars should be defined with DEFINE_STATIC_LOCAL otherwise this code won't compile on Mac OS. See also JavaScriptCore/wtf/StdLibExtras.h
Comment 1 Philippe Normand 2010-03-26 04:17:59 PDT
Created attachment 51726 [details]
proposed patch
Comment 2 WebKit Review Bot 2010-03-26 04:20:27 PDT
Attachment 51726 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Philippe Normand 2010-03-29 00:41:20 PDT
Landed in r56710. Thanks!