Bug 36637 - Remove some evil statics from CommitInfo
Summary: Remove some evil statics from CommitInfo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-25 18:40 PDT by Adam Barth
Modified: 2010-03-26 10:32 PDT (History)
2 users (show)

See Also:


Attachments
Patch (7.66 KB, patch)
2010-03-25 18:41 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-03-25 18:40:13 PDT
Remove some evil statics from CommitInfo
Comment 1 Adam Barth 2010-03-25 18:41:36 PDT
Created attachment 51708 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-03-26 00:52:18 PDT
Comment on attachment 51708 [details]
Patch

OK.  But where are the tests?
Comment 3 Adam Barth 2010-03-26 10:10:02 PDT
Comment on attachment 51708 [details]
Patch

I didn't change any behavior.  I just moved code around.  :)

We should write some Checkout tests though.
Comment 4 WebKit Commit Bot 2010-03-26 10:32:38 PDT
Comment on attachment 51708 [details]
Patch

Clearing flags on attachment: 51708

Committed r56632: <http://trac.webkit.org/changeset/56632>
Comment 5 WebKit Commit Bot 2010-03-26 10:32:43 PDT
All reviewed patches have been landed.  Closing bug.