Bug 36636 - Move modified_changelogs (and friends) from scm to checkout
Summary: Move modified_changelogs (and friends) from scm to checkout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-25 18:09 PDT by Adam Barth
Modified: 2010-03-25 22:38 PDT (History)
1 user (show)

See Also:

Attachments
Patch (10.40 KB, patch)
2010-03-25 18:11 PDT, Adam Barth 		eric: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-03-25 18:09:28 PDT 
Move modified_changelogs (and friends) from scm to checkout
Comment 1 Adam Barth 2010-03-25 18:11:36 PDT 
Created attachment 51705 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-03-25 18:13:26 PDT 
Comment on attachment 51705 [details]
Patch

Yay!

Heck, is_path_to_ChangeLog could possibly just move to checkout now.
Comment 3 Adam Barth 2010-03-25 18:15:07 PDT 
Comment on attachment 51705 [details]
Patch

yep
Comment 4 WebKit Commit Bot 2010-03-25 21:23:25 PDT 
Comment on attachment 51705 [details]
Patch

Rejecting patch 51705 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1
Last 500 characters of output:
FAILED at 373.
1 out of 2 hunks FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/tool/mocktool.py.rej
patching file WebKitTools/Scripts/webkitpy/tool/steps/abstractstep.py
patching file WebKitTools/Scripts/webkitpy/tool/steps/preparechangelogforrevert.py
patching file WebKitTools/Scripts/webkitpy/tool/steps/revertrevision.py
patching file WebKitTools/Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py
patching file WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py

Full output: http://webkit-commit-queue.appspot.com/results/1389008
Comment 5 Adam Barth 2010-03-25 22:38:57 PDT 
Committed r56601: <http://trac.webkit.org/changeset/56601>