Move commit_message_for_this_commit from scm to checkout
Created attachment 51695 [details] Patch
Comment on attachment 51695 [details] Patch Do you mean to move the FIXME? Did you need to delete a mock after this?
Comment on attachment 51695 [details] Patch Yeah, I need to remove the FIXME. There's no mock to remove because our SCM mock inherits from Mock and is really loose.
Comment on attachment 51695 [details] Patch Clearing flags on attachment: 51695 Committed r56592: <http://trac.webkit.org/changeset/56592>
All reviewed patches have been landed. Closing bug.
Committed r56599: <http://trac.webkit.org/changeset/56599>
Created attachment 51715 [details] Patch
I should have opened a new bug, but oh well.
Comment on attachment 51715 [details] Patch Doesn't this test leave junk files in the file system? We shouldn't be writing to the actual file system. We should mock out that part too.
I had it different originally. It was using a temp svn checkout. Then I realized I didn't need the checkout. I'll fix.
Created attachment 51717 [details] Patch
We could split this method up into multiple smaller methods to allow easier mocking. But for now I've just used a temporary directory for holding these ChagneLogs. If we're adding more API tests which don't want the setUp/tearDown methods, then we should consider making this its own Test class, or using try/finally to make sure the setup/teardown is always run.
Comment on attachment 51717 [details] Patch I don't think we should be writing to the file system in a unit test.
Argued out in person.
Committed r56638: <http://trac.webkit.org/changeset/56638>
Created attachment 51775 [details] Patch for landing
Re-open to let the commit-queue see this bug.
Comment on attachment 51775 [details] Patch for landing Hacking the commit-queue to land this first.
Comment on attachment 51775 [details] Patch for landing Make our tools work!
Comment on attachment 51775 [details] Patch for landing Clearing flags on attachment: 51775 Committed r56643: <http://trac.webkit.org/changeset/56643>